Skip to content

Respect the AsyncRequestProducer contract by properly implementing available() method #3235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reta wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −1
Open

Respect the AsyncRequestProducer contract by properly implementing available() method #3235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion .../main/java/org/apache/cxf/transport/http/asyncclient/hc5/CXFHttpAsyncRequestProducer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,24 @@ private void resetRequest() {

@Override
public int available() {
return 0;
if (content != null) {
final ByteBuffer b = buffer;
if (b != null && b.hasRemaining()) {
return b.remaining();
}
final InputStream in = fis;
if (in != null) {
try {
return in.available();
} catch (final IOException ex) {
/* Nothing to do */
}
}
} else if (buf != null && buf.hasData()) {
return buf.length(); /* returns remaining */
}

return 0; /* no more data */
}

@Override
Expand Down
Loading