Skip to content

ATLAS-5374: Remove Related Categories / Parent column from glossary AUDIT export (CSV/XLSX) #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
UmeshPatil-1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ATLAS-5374: Remove Related Categories / Parent column from glossary AUDIT export (CSV/XLSX) #725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions repository/src/main/java/org/apache/atlas/glossary/GlossaryExportWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ public class GlossaryExportWriter {

private static final String[] AUDIT_HEADERS = {
"Record Type", "Name", "Glossary Name", "Short Description", "Long Description",
"Status", "Classifications", "Custom Attributes", "Related Categories / Parent",
"Qualified Name", "GUID"
"Status", "Classifications", "Custom Attributes", "Qualified Name", "GUID"
};

public void write(OutputStream outputStream, List<GlossaryExportRow> rows,
Expand Down Expand Up @@ -133,7 +132,6 @@ private String[] toAuditRow(GlossaryExportRow row) {
safe(row.getStatus()),
safe(row.getClassifications()),
safe(row.getCustomAttributes()),
safe(row.getRelatedCategoriesOrParent()),
safe(row.getQualifiedName()),
safe(row.getGuid())
};
Expand Down
5 changes: 5 additions & 0 deletions repository/src/test/java/org/apache/atlas/glossary/GlossaryExportWriterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ public void testWriteAuditCsv() throws Exception {
assertTrue(csv.contains("BankBranch"));
assertTrue(csv.contains("testBankingGlossary"));
assertTrue(csv.contains("Record Type"));
assertTrue(!csv.contains("Related Categories / Parent"));

}

@Test
Expand All @@ -71,6 +73,9 @@ public void testWriteAuditXlsx() throws Exception {
Row data = sheet.getRow(1);

assertEquals(header.getCell(0).getStringCellValue(), "Record Type");
assertEquals(header.getCell(8).getStringCellValue(), "Qualified Name");
assertEquals(header.getCell(9).getStringCellValue(), "GUID");
assertEquals(header.getLastCellNum(), (short) 10);
assertEquals(data.getCell(1).getStringCellValue(), "BankBranch");
assertEquals(data.getCell(2).getStringCellValue(), "testBankingGlossary");
}
Expand Down