fix(opentelemetry): recreate tracer object after plugin metadata changed#13618
Open
shreemaan-abhishek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
opentelemetryplugin caches the tracer object per route viacore.lrucache.plugin_ctx, but passednilas the cache version key in_M.rewrite. The tracer bakes in everything sourced fromplugin_metadata(collector address,request_timeout/request_headers,trace_id_source, sampler, and resource attributes). With anilversion key the cache entry is never invalidated, so after an operator updates theopentelemetryplugin_metadata at runtime (e.g. points to a new OTLP collector or flipstrace_id_source), the worker keeps serving the stale cached tracer. Spans keep going to the old endpoint until the per-conf cache entry is evicted or the worker recycles.This passes
metadata.modifiedIndexas the lrucache version key so the tracer is rebuilt whenever the plugin_metadata changes.api_ctx.conf_version(the existing version) only tracks the route/service, not plugin_metadata, so a metadata-only change does not invalidate the entry on its own.Fixes the stale-tracer behavior on plugin_metadata change.
Checklist