Skip to content

indexstorage: drop legacy oh key - #240

Merged
cheggaaa merged 1 commit into
mainfrom
cheggaaa/index-drop-legacy-oldhash
Sep 19, 2026
Merged

cheggaaa merged 1 commit into
mainfrom
cheggaaa/index-drop-legacy-oldhash

Conversation

@cheggaaa

@cheggaaa cheggaaa commented Aug 10, 2026 •

Copy link
Copy Markdown
Member

The legacy diff hash key (oh) is dead since diffsync V2 removal (#231), but stale values written by older versions stay in existing space docs forever, and SetSpaceStatus(Remove) still writes an oh: null field into docs that never had one.

  • UpdateHash deletes oh from the doc it rewrites, so legacy docs self-clean on their next hash update
  • SetSpaceStatus(Remove) deletes the key instead of nulling it, so the field is never added

🤖 Generated with Claude Code

@github-actions

Copy link
Copy Markdown

New Coverage 50.9% of statements
Patch Coverage 100.0% of changed statements (6/6)

Coverage provided by https://github.com/seriousben/go-patch-cover-action

@requilence
requilence self-requested a review September 19, 2026 13:52
@cheggaaa
cheggaaa merged commit 953b4de into main Sep 19, 2026
6 checks passed
@cheggaaa
cheggaaa deleted the cheggaaa/index-drop-legacy-oldhash branch September 19, 2026 15:27
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants