Repository navigation
indexstorage: drop legacy oh key - #240
Merged
Merged
Conversation
Coverage provided by https://github.com/seriousben/go-patch-cover-action |
requilence
self-requested a review
September 19, 2026 13:52
requilence
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy diff hash key (
oh) is dead since diffsync V2 removal (#231), but stale values written by older versions stay in existing space docs forever, andSetSpaceStatus(Remove)still writes anoh: nullfield into docs that never had one.UpdateHashdeletesohfrom the doc it rewrites, so legacy docs self-clean on their next hash updateSetSpaceStatus(Remove)deletes the key instead of nulling it, so the field is never added🤖 Generated with Claude Code