Clarify TLS scans without non-PQC probing#15
Open
leemeo3 wants to merge 1 commit into
Open
Conversation
leemeo3
marked this pull request as ready for review
June 12, 2026 00:53
Author
|
Rechecked this with a local OpenSSL TLS server restricted to classical groups ( On current
With On this PR branch, the same default scan returns Validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nonpqc_algosasnullwhen a TLS scan did not run non-PQC group probes--test-nonpqc-algoswhen no configured PQC groups are detectedWhy
Issue #13 reports TLS scan output where the connection succeeds (
error: null) but all algorithm lists are empty. I reproduced the same default-scan shape withwww.openssl.org:443andbadssl.com:443.The default TLS scan only probes configured PQC groups unless
--test-nonpqc-algosis supplied. Returningnonpqc_algos: []made that look like non-PQC groups were tested and none were found. Returningnullkeeps the existing optional field semantics and distinguishes "not tested" from an empty tested result.Validation
rustfmt --edition 2021 --check src/tls.rscargo testcargo build./target/debug/pqcscan tls-scan -t www.openssl.org:443 -o /tmp/pqcscan-openssl-after-default.json./target/debug/pqcscan tls-scan -t www.openssl.org:443 --test-nonpqc-algos -o /tmp/pqcscan-openssl-after-nonpqc.json./target/debug/pqcscan tls-scan -t pq.cloudflareresearch.com:443 -o /tmp/pqcscan-cloudflare-after.jsonNotes
Full
cargo fmt --checkandcargo clippy --all-targets --all-featuresstill fail on existing baseline issues outside the scope of this patch.