clamp startIndex in subString to avoid unsigned length underflow - #242
Open
zayeem06 wants to merge 1 commit into
Open
clamp startIndex in subString to avoid unsigned length underflow#242zayeem06 wants to merge 1 commit into
zayeem06 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subString8 and subStringUTF16 only clamp the upper index and then compute the copy length as endIndex - startIndex in unsigned arithmetic, so a call where startIndex is past endIndex (for example subString(s, 6, 5)) wraps the length to roughly 0xFFFFFFFF. That value reaches newPtr8/newSize8 where size + 1 overflows to 0, so a minimal buffer is allocated and the following memmove copies about 4GB, which AddressSanitizer flags as a heap overflow at newPtr8. subString is a public string method that generated parsers and grammar actions use to slice token text with offsets derived from the input, so reversed offsets are reachable. The fix clamps startIndex to endIndex in both functions so the subtraction can no longer underflow. Reviewers may want to confirm that ordinary substrings are untouched, which they are since the guard only fires when startIndex already exceeds endIndex.