Skip to content

Fix missing Metal object header dependencies - #1037

Open
IngeniousIdiocy wants to merge 1 commit into
antirez:mainfrom
IngeniousIdiocy:fix-metal-header-dependencies
Open

IngeniousIdiocy wants to merge 1 commit into
antirez:mainfrom
IngeniousIdiocy:fix-metal-header-dependencies

Conversation

@IngeniousIdiocy

@IngeniousIdiocy IngeniousIdiocy commented Sep 13, 2026

Copy link
Copy Markdown

Rebuild ds4_metal.o when ds4.h or ds4_image.h changes.

Build passes on macOS; make -n -W <header> ds4_metal.o confirms both headers now trigger recompilation.

@IngeniousIdiocy
IngeniousIdiocy force-pushed the fix-metal-header-dependencies branch from 0a3cac4 to a32a030 Compare September 14, 2026 01:57

@emilianbold emilianbold left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct but I wonder if we should't use https://www.gnu.org/software/make/manual/make.html#Generating-Prerequisites-Automatically or something similar so these makefile header dependencies don't drift so much.

@IngeniousIdiocy

Copy link
Copy Markdown
Author

This is correct but I wonder if we should't use https://www.gnu.org/software/make/manual/make.html#Generating-Prerequisites-Automatically or something similar so these makefile header dependencies don't drift so much.

entirely up to you guys. I normally play in my own branch of ds4 doing things not really appropriate for the whole project but this one felt like I owed a PR. thanks for all the work in maintaining it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants