Fix missing Metal object header dependencies - #1037
Open
IngeniousIdiocy wants to merge 1 commit into
Open
IngeniousIdiocy wants to merge 1 commit into
IngeniousIdiocy wants to merge 1 commit into
Conversation
IngeniousIdiocy
force-pushed
the
fix-metal-header-dependencies
branch
from
September 14, 2026 01:57
0a3cac4 to
a32a030
Compare
emilianbold
approved these changes
Sep 14, 2026
emilianbold
left a comment
There was a problem hiding this comment.
This is correct but I wonder if we should't use https://www.gnu.org/software/make/manual/make.html#Generating-Prerequisites-Automatically or something similar so these makefile header dependencies don't drift so much.
Author
entirely up to you guys. I normally play in my own branch of ds4 doing things not really appropriate for the whole project but this one felt like I owed a PR. thanks for all the work in maintaining it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuild
ds4_metal.owhends4.hords4_image.hchanges.Build passes on macOS;
make -n -W <header> ds4_metal.oconfirms both headers now trigger recompilation.