Fix numeric operator operand context isolation#124
Merged
Conversation
Predicate evaluation on a left-hand numeric operand can leave the shared navigator on a different node before the right-hand operand runs. Snapshot and restore the operator context around each operand, with eager number coercion, and add regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Predicate evaluation on a left-hand numeric operand can leave the shared navigator
on a different node before the right-hand operand is evaluated. Context-sensitive
RHS expressions (for example
count(self::Name)) then observe the wrong context.This change isolates operand evaluation context in
numericQuery.Evaluate(snapshotcontext, eager
asNumberper operand, restore) and adds regression tests for thepredicated-sum × context-sensitive-factor class, with literal-factor and factor-first
controls.