service layer#5274
Draft
mayankansys wants to merge 1 commit into
Draft
Conversation
Up to standards ✅🟢 Issues
|
mayankansys
commented
Jul 21, 2026
| """ | ||
| if self._rest_client is not None: | ||
| return RestSettings(self._rest_client) | ||
| return None |
Collaborator
Author
There was a problem hiding this comment.
Never return the None, we have to handle it via error or warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
What was the situation or problem before this change?
Change Summary
What changes were made?
Rationale
Why was this approach taken?
Impact
What parts of the system or workflows are affected?