chore: Unify schema attrs in flobject.py#5256
Conversation
Up to standards ✅🟢 Issues
|
| cls._allowed_values = allowed_values | ||
|
|
||
| has_migration_adapter = info.get("has-migration-adapter?", False) | ||
| has_migration_adapter = info.get("has_migration_adapter", False) |
There was a problem hiding this comment.
Only this we need to add. I am not sure how it was getting propagated from settings side as I could not find this attribute in the schema (proto of in the server code.)
@mkundu1
There was a problem hiding this comment.
@prmukherj Please see https://github.com/ansys-internal/ansys-api-fluent/pull/180/changes how the settings schema can be restructured to avoid the dynamic attrs and the scheme names like has-migration-adapter? etc.
Please also note: https://github.com/ansys-internal/ansys-api-fluent/issues/121
3 participants
Context
What was the situation or problem before this change?
Change Summary
What changes were made?
Rationale
Why was this approach taken?
Impact
What parts of the system or workflows are affected?