FEAT: spisim compute com from single snp with THRU FEXT NEXT#7855
Draft
hui-zhou-a wants to merge 39 commits into
Draft
FEAT: spisim compute com from single snp with THRU FEXT NEXT#7855hui-zhou-a wants to merge 39 commits into
hui-zhou-a wants to merge 39 commits into
Conversation
…into refactor-spisim-com # Conflicts: # src/ansys/aedt/core/visualization/post/spisim.py
| try: | ||
| import skrf as rf | ||
|
|
||
| except ImportError: |
Collaborator
There was a problem hiding this comment.
I think we do have a decorator for that kind of situation. Please try to use it.
Contributor
Author
There was a problem hiding this comment.
I copied these lines from TouchstoneData. @Samuelopez-ansys @SMoraisAnsys could you guide me which decorator I should use?
Collaborator
There was a problem hiding this comment.
In fact the current decorator is only working for graphical dependencies. Can you wait a bit with your PR so that I can add it ?
Contributor
Author
There was a problem hiding this comment.
@SMoraisAnsys could you give a update on this?
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
… into proposal_pydantic_for_arguments # Conflicts: # src/ansys/aedt/core/modeler/circuits/primitives_circuit.py
… into proposal_pydantic_for_arguments # Conflicts: # src/ansys/aedt/core/modeler/circuits/primitives_circuit.py
… into refactor-spisim-com
Samuelopez-ansys
marked this pull request as draft
July 1, 2026 12:50
hui-zhou-a
marked this pull request as ready for review
July 1, 2026 18:30
hui-zhou-a
marked this pull request as draft
July 1, 2026 18:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue linked
#7856
Checklist