Skip to content

FEAT: Add new class for named selections#7832

Draft
gmalinve wants to merge 30 commits into
mainfrom
feat/create_get_named_selections
Draft

FEAT: Add new class for named selections#7832
gmalinve wants to merge 30 commits into
mainfrom
feat/create_get_named_selections

Conversation

@gmalinve

@gmalinve gmalinve commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Description

In this PR I added a new class to handle NamedSelections list and make old class List backward compatible with older versions of AEDT.
The new class handles: create, rename, update and delete.

Issue linked

#7830

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue(s) that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have agreed with the Contributor License Agreement (CLA).

@gmalinve gmalinve self-assigned this Jun 24, 2026
@github-actions github-actions Bot added the enhancement New features or code improvements label Jun 24, 2026
@gmalinve
gmalinve marked this pull request as ready for review June 24, 2026 14:53
@gmalinve
gmalinve requested a review from a team as a code owner June 24, 2026 14:53
SMoraisAnsys
SMoraisAnsys previously approved these changes Jun 24, 2026

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you just add a test working with ids instead of names ?

Comment thread tests/system/general/test_primitives_3d.py
@Samuelopez-ansys

Copy link
Copy Markdown
Member

Hi @gmalinve ,

Named selections is the old ¨Lists¨ in AEDT. Please review first the class Lists in modeler.

Prabably it is still valid, but you could transition to NamedSelections because it seems the future. In addition, this feature is available from recent versions so this should be also controlled.

@Samuelopez-ansys
Samuelopez-ansys marked this pull request as draft June 26, 2026 06:58
@gmalinve
gmalinve requested a review from Samuelopez-ansys July 3, 2026 09:50
@gmalinve gmalinve changed the title FEAT: Add create named selection and get obejcts from named selections FEAT: Add new class for named selections Jul 3, 2026
@gmalinve gmalinve linked an issue Jul 3, 2026 that may be closed by this pull request
@gmalinve
gmalinve marked this pull request as ready for review July 3, 2026 13:55
Comment thread src/ansys/aedt/core/modeler/cad/modeler.py Outdated
@gmalinve
gmalinve requested a review from SMoraisAnsys July 3, 2026 14:00
@gmalinve
gmalinve requested a review from eblanco-ansys July 21, 2026 11:55
@eblanco-ansys
eblanco-ansys marked this pull request as draft July 21, 2026 14:55
@gmalinve
gmalinve requested a review from Alberto-DM July 22, 2026 14:24
@gmalinve
gmalinve marked this pull request as ready for review July 22, 2026 14:24
@gmalinve
gmalinve marked this pull request as draft July 23, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose named selections list

5 participants