-
Notifications
You must be signed in to change notification settings - Fork 265
CHORE: Delete deprecation #7674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Samuelopez-ansys
wants to merge
70
commits into
main
Choose a base branch
from
chore/delete_deprecation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
a060e68
CHORE: remove deprecated enumeration classes from constants.py
158adbb
CHORE: remove deprecated analyze argument from export functions
878ea30
CHORE: remove deprecated analyze argument from export functions
c2ec4f8
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] 687f3be
chore: adding changelog file 7674.maintenance.md [dependabot-skip]
pyansys-ci-bot 87d4c39
chore: update type hints for assignment parameter in multiple functions
0326cab
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] 4b09e43
fix deprecated argument
163b294
Merge branch 'main' into chore/delete_deprecation
504a2b7
Merge branch 'main' into chore/delete_deprecation
Samuelopez-ansys b1190f6
CHORE: simplify use_convolution parameter by removing None type hint
bae5a97
Remove all deprecated methods and properties
9ec7dd2
fix: correct docstring formatting in job_status method
6660000
fix: raise ImportError for missing pandas instead of logging error
54729dc
fix: update export_netlist_from_schematic method to raise exceptions …
a3c5219
fix: raise ValueError for invalid port_selector in get_source_pin_nam…
86c56af
fix: raise exceptions for invalid input file and ports in assign_volt…
b4b9eaa
fix: raise exceptions for invalid input file and improve error handli…
4efd6f1
fix: raise AEDTRuntimeError for missing component name in create_ibis…
b0905d7
fix: improve error handling in import_table and delete_imported_data …
2d5e706
fix: raise AEDTRuntimeError for failed port creation and update in ed…
a6cd567
fix: raise AEDTRuntimeError for failed port creation and update in ed…
6052a87
fix: add validation to prevent duplicate ports in create_coax_port me…
380685b
fix: replace RuntimeError with AEDTRuntimeError for port creation and…
0262c61
fix: raise ValueError for invalid CAD format in import methods
f5ae3da
fix: raise ValueError for invalid interpolation algorithm in edit_cos…
a7bf06b
fix: improve error handling and raise AEDTRuntimeError for various fa…
4afff4a
fix: enhance error handling in show_extent method and update test cases
aadb425
fix: improve error handling in import methods and update test cases
cb3fc82
fix: update return types and improve error handling in sweep creation…
5c34ee3
fix: update return type and improve error handling in create_single_p…
0c7c7d2
fix: update return type and raise AEDTRuntimeError in set_differentia…
9e17422
fix: update return types and improve error handling in export methods
7506cba
fix: update type hints and improve error handling in HFSS methods
67b5a18
fix: update parse_hdm_file return type and improve error handling
c01845f
fix: update return types and improve type handling in HFSS methods
1246b3c
fix: replace error logging with exceptions for better error handling …
a407a48
Merge branch 'main' into chore/delete_deprecation
3d96aac
fix: replace error logging with exceptions for CSV parsing failure in…
821a6f5
fix: replace error logging with exceptions for better error handling …
37b3fc2
fix: replace error logging with exceptions for input validation in 2D…
006c6ae
fix: replace return False with exceptions for fan and PCB creation fa…
42324c0
fix: replace return False with exceptions for fan and PCB creation fa…
e73d827
fix: replace return False with exceptions for error handling in PCB m…
3825cc7
fix: raise ValueError for missing waveguide dimensions in get_wavegui…
a43c29c
fix: replace error logging with exceptions for invalid project names …
99dfdce
fix: replace error logging with exceptions for invalid project names …
fabf796
fix: replace error logging with exceptions for pin connection failure…
a3b9d79
fix: replace error logging with exceptions for invalid inputs in sche…
24c569d
Test if 2026R1 fixes old bugs
5da8e8e
fix: replace boolean return values with exceptions for connection fai…
0072fc9
fix: replace boolean return values with exceptions for winding assign…
4184c05
fix: raise exceptions for invalid clearance application on non-compon…
aff1fb2
fix: replace boolean return values with exceptions for undefined setu…
da16ab4
fix: replace boolean return values with exceptions for invalid inputs…
21c5720
fix: replace boolean return values with exceptions for invalid inputs…
05857b7
fix: replace boolean return values with exceptions for failure cases …
f701f2a
Merge branch 'main' into chore/delete_deprecation
9182c4f
fix: replace boolean return values with exceptions for error handling…
bdefebf
FIX UT
4b93f0d
test: add exception handling for assign_2way_coupling in setup creation
f59ce9b
fix: update return types to improve error handling in design and farf…
b709590
fix: improve error handling in modeler_3d by raising exceptions for c…
99584c7
fix: update model property references to improve clarity and consistency
0a25e07
fix: update object existence checks in 3D primitive creation functions
e2a2362
REFACTOR(report/common): Avoid return false and raise instead
SMoraisAnsys ce148b4
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] b2f0134
REFACTOR(report/common): Avoid return false and raise instead
SMoraisAnsys 629612b
REFACTOR: Update changes in b2f0134989d7 and add fixes
SMoraisAnsys 0211e4e
Merge branch 'chore/delete_deprecation' of github.com:ansys/pyaedt in…
SMoraisAnsys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Delete deprecation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we be removing the method and not the "deprecated:: ..." in the docstring ?
Can be performed in another PR were all deprecated mthods (not arguments) are removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SMoraisAnsys We decided that this method should not be deprecated, historically, many users have it, and it is useful to have it at design level.