Skip to content

FEAT: waveport object advanced config - #6595

Draft
eblanco-ansys wants to merge 40 commits into
mainfrom
feat/waveport_object_alignment
Draft

FEAT: waveport object advanced config#6595
eblanco-ansys wants to merge 40 commits into
mainfrom
feat/waveport_object_alignment

Conversation

@eblanco-ansys

Copy link
Copy Markdown
Contributor

Description

Added WavePortObject class to handle waveport advanced configuration in HFSS

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@eblanco-ansys eblanco-ansys self-assigned this Sep 1, 2025
@github-actions github-actions Bot added the enhancement New features or code improvements label Sep 1, 2025
@eblanco-ansys eblanco-ansys changed the title Feat/waveport object alignment FEAT: waveport object alignment Sep 2, 2025
@codecov

codecov Bot commented Sep 2, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 22.16359% with 295 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.40%. Comparing base (712cc33) to head (e7a7c5a).
⚠️ Report is 400 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6595       +/-   ##
===========================================
- Coverage   83.32%   28.40%   -54.92%     
===========================================
  Files         246      246               
  Lines       77442    77808      +366     
===========================================
- Hits        64527    22104    -42423     
- Misses      12915    55704    +42789     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eblanco-ansys
eblanco-ansys marked this pull request as ready for review September 3, 2025 09:11
@eblanco-ansys
eblanco-ansys requested a review from a team as a code owner September 3, 2025 09:11
@eblanco-ansys eblanco-ansys changed the title FEAT: waveport object alignment FEAT: waveport object advanced config Sep 3, 2025
@Samuelopez-ansys
Samuelopez-ansys marked this pull request as draft September 4, 2025 05:54
@Devin-Crawford
Devin-Crawford self-requested a review September 4, 2025 09:27
@eblanco-ansys
eblanco-ansys marked this pull request as ready for review September 5, 2025 06:40

@Devin-Crawford Devin-Crawford left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still lots of work to do on this.

Comment thread tests/system/general/test_hfss_excitations.py
Comment thread tests/system/general/test_hfss_excitations.py Outdated
@eblanco-ansys
eblanco-ansys marked this pull request as draft September 5, 2025 15:03
@Samuelopez-ansys

Copy link
Copy Markdown
Member

Next week I will review it, thank you @eblanco-ansys for this great contribution

@Devin-Crawford

Copy link
Copy Markdown
Contributor

The unit test now creates only one box for the waveguide, but it creates multiple port instances on the same face which would lead to an invalid project. It would be good to

  1. Save the project (this generally improve stability and reduces the likelihood of a crash during the test.
  2. Create a valid project and test all of the wave port methods on a single port instance.

@Devin-Crawford

Copy link
Copy Markdown
Contributor

@eblanco-ansys : Actually it would be good to raise an exception if trying to assign a port to a face where a port has already been assigned ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants