chore: update the handling of uv dependabot updates - #1425
Conversation
|
Looking at your changes it doesn't seem to be reverted so I am fine with it |
Co-authored-by: Revathy Venugopal <104772255+Revathyvenugopal162@users.noreply.github.com>
SMoraisAnsys
left a comment
There was a problem hiding this comment.
@moe-ad can you remind us what is the benefit of working with X.Y specificly ? When we discussed about that in the past, the goal was to reduce the number of PR opened by dependabot to lessen the load associated to CI bumps.
AFAIK this is working fine currently and allows us to update packages less often. The proposed changes are going to add an extra manual layer. Isn't that counter productive ?
SMoraisAnsys
left a comment
There was a problem hiding this comment.
Adding a request for changes review to ensure a response to my previous comment before any merge :)
Hi @SMoraisAnsys. If you read the PR description, I already made a comment about this:
FYI that this is the feedback that led to us taking this approach initially and I am personally fine with either approach (the manual step isn't much work and it doesn't happen often). Though I must say that given that we do not yet know every possible way the ongoing effort to add more uv support might be impacted by the action dependencies, meaning we might require more iterations of the implementation in the future (overhaul how we are consuming dependencies for example), it might make sense to retain the flexibility pinning to |
|
As long as we keep using pinned dependencies and have a valid and secure way to update the dependencies on a regular base, I don't have any strong opinion. If you think that this won't add too much on your plate then you can test things and give us your feedback later. |
The changes made in #1401 did not work as expected, examples:
So in this PR, I am:
pyproject.tomlchanges that have been merged.ci_cd_dependabot.ymlto add a note to the end ofuvdependabot PR description so that we are reminded to verify anypyproject.tomlchanges in subsequent PRs before merging. The note will look like this. Already discussed this with @SMoraisAnsys as a fallback approach in the past.We can also decide to stop worrying about restricting the bounds in the
pyproject.tomlaltogether. We can then observe by how much the CI load would actually increase and then decide if we are fine with that.