Skip to content

chore: update the handling of uv dependabot updates - #1425

Open
moe-ad wants to merge 4 commits into
mainfrom
chore/update-handling-of-uv-dependabot-updates
Open

chore: update the handling of uv dependabot updates#1425
moe-ad wants to merge 4 commits into
mainfrom
chore/update-handling-of-uv-dependabot-updates

Conversation

@moe-ad

@moe-ad moe-ad commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

The changes made in #1401 did not work as expected, examples:

So in this PR, I am:

  • Reverting the changes made in chore: ignore patch updates for uv package ecosystem #1401.
  • Updating all the undesirable pyproject.toml changes that have been merged.
  • Adding a job to ci_cd_dependabot.yml to add a note to the end of uv dependabot PR description so that we are reminded to verify any pyproject.toml changes in subsequent PRs before merging. The note will look like this. Already discussed this with @SMoraisAnsys as a fallback approach in the past.

We can also decide to stop worrying about restricting the bounds in the pyproject.toml altogether. We can then observe by how much the CI load would actually increase and then decide if we are fine with that.

@moe-ad moe-ad self-assigned this Jul 23, 2026
@moe-ad
moe-ad requested a review from a team as a code owner July 23, 2026 12:34
@github-actions github-actions Bot added the ci Pipelines maintenance related label Jul 23, 2026
@RobPasMue

Copy link
Copy Markdown
Member

@moe-ad - watch out with #1419 ...

I had to change the behavior of the scripts to align with ghapi 2.X (which is not a patch update - it's a major bump!)

@RobPasMue

Copy link
Copy Markdown
Member

Looking at your changes it doesn't seem to be reverted so I am fine with it

Comment thread .github/workflows/ci_cd_dependabot.yml Outdated
Comment thread .github/workflows/ci_cd_dependabot.yml Outdated
Co-authored-by: Revathy Venugopal <104772255+Revathyvenugopal162@users.noreply.github.com>

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moe-ad can you remind us what is the benefit of working with X.Y specificly ? When we discussed about that in the past, the goal was to reduce the number of PR opened by dependabot to lessen the load associated to CI bumps.
AFAIK this is working fine currently and allows us to update packages less often. The proposed changes are going to add an extra manual layer. Isn't that counter productive ?

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a request for changes review to ensure a response to my previous comment before any merge :)

@moe-ad

moe-ad commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@moe-ad can you remind us what is the benefit of working with X.Y specificly ? When we discussed about that in the past, the goal was to reduce the number of PR opened by dependabot to lessen the load associated to CI bumps. AFAIK this is working fine currently and allows us to update packages less often. The proposed changes are going to add an extra manual layer. Isn't that counter productive ?

Hi @SMoraisAnsys. If you read the PR description, I already made a comment about this:

We can also decide to stop worrying about restricting the bounds in the pyproject.toml altogether. We can then observe by how much the CI load would actually increase and then decide if we are fine with that.

FYI that this is the feedback that led to us taking this approach initially and I am personally fine with either approach (the manual step isn't much work and it doesn't happen often).

Though I must say that given that we do not yet know every possible way the ongoing effort to add more uv support might be impacted by the action dependencies, meaning we might require more iterations of the implementation in the future (overhaul how we are consuming dependencies for example), it might make sense to retain the flexibility pinning to major.minor in the pyproject.toml offers us.

@moe-ad
moe-ad requested a review from SMoraisAnsys July 29, 2026 12:29
@SMoraisAnsys

Copy link
Copy Markdown
Contributor

As long as we keep using pinned dependencies and have a valid and secure way to update the dependencies on a regular base, I don't have any strong opinion. If you think that this won't add too much on your plate then you can test things and give us your feedback later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Pipelines maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants