Skip to content

fix(code-style): use uv sync if lock file is present #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jorgepiloto wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(code-style): use uv sync if lock file is present #1088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ea66251
fix(code-style): use uv sync if lock file is present
jorgepiloto Dec 3, 2025
000816d
Merge branch 'main' into fix/code-style-with-uv
jorgepiloto Dec 3, 2025
2b15273
chore: adding changelog file 1088.fixed.md [dependabot-skip]
pyansys-ci-bot Dec 3, 2025
0b28571
Merge branch 'main' into fix/code-style-with-uv
moe-ad Dec 16, 2025
b641a5c
Merge branch 'main' into fix/code-style-with-uv
jorgepiloto Jan 12, 2026
4e45d4c
fix: check-vulnerabilities
jorgepiloto Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion check-vulnerabilities/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,11 @@ runs:
if [[ "${BUILD_BACKEND}" == 'poetry' ]]; then
poetry install --extras "${extra_targets}"
elif [[ "${BUILD_BACKEND}" == 'uv' ]]; then
uv pip install ."${extra_targets}"
if [ -f "uv.lock" ]; then
uv sync --extra "${extra_targets}"

@da1910 da1910 Jan 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uv sync --extra "${extra_targets}"
uv sync --extra "${extra_targets}" --frozen

If we're using the lock file we need to not regenerate it when we sync

@SMoraisAnsys SMoraisAnsys Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah and we might not want to use dev dependencies so I'd add --no-dev too

else
uv pip install ."${extra_targets}"
fi
else
python -m pip install ."${extra_targets}"
fi
Expand Down
6 changes: 5 additions & 1 deletion code-style/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,11 @@ runs:
if [[ "${BUILD_BACKEND}" == 'poetry' ]]; then
poetry install
elif [[ "${BUILD_BACKEND}" == 'uv' ]]; then
uv pip install .
if [ -f "uv.lock" ]; then
uv sync

@da1910 da1910 Jan 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uv sync
uv sync --frozen

else
uv pip install .
fi
Comment on lines +253 to +257

@moe-ad moe-ad Dec 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgepiloto I was wondering if we could extend this to _doc-build-linux, _doc-build-windows, build-wheelhouse, check-vulnerabilities, and tests-pytest. Those are the actions I have noted where something similar to this might be needed (I am not sure if I am missing some others).

Or we could address those in a separate PR if that is what you prefer.

else
python -m pip install .
fi
Expand Down
1 change: 1 addition & 0 deletions doc/source/changelog/1088.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Use uv sync if lock file is present
Loading