Repository navigation
Conversation
Tag heavy targets with `heavy/<backend>` aliases, define one session per backend in antsibull-nox.toml, and add a manually triggered nox-heavy-rundeck workflow. The aliases extra sanity check now requires every heavy backend to have a tagged session and its own workflow. Assisted-by: Claude Opus 5.5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
russoz
force-pushed
the
heavy-tests-gha
branch
from
October 30, 2026 22:58
9ccc7c9 to
cf491f6
Compare
russoz
marked this pull request as ready for review
October 30, 2026 23:27
Assisted-by: Claude Opus 5.5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
Failures in nox session |
felixfontein
left a comment
Collaborator
There was a problem hiding this comment.
Thanks again for working on this!
Comment on lines
+15
to
+18
| try: | ||
| import tomllib | ||
| except ImportError: | ||
| import tomli as tomllib |
Collaborator
There was a problem hiding this comment.
Since tomllib has been around since Python 3.11, let's remove the try and tomli fallback. This will also fix the mypy errors.
| import tomli as tomllib | ||
|
|
||
|
|
||
| def get_heavy_targets(): |
Collaborator
There was a problem hiding this comment.
Suggested change
| def get_heavy_targets(): | |
| def get_heavy_targets() -> tuple[set[str], bool]: |
| return targets, has_errors | ||
|
|
||
|
|
||
| def main(): |
Collaborator
There was a problem hiding this comment.
Also try to see whether this "just works". If not, I can fix it in a follow-up.
Suggested change
| def main(): | |
| def main() -> None: |
| ``` | ||
|
|
||
| Additional options for `ansible-test` can be passed after `--`. | ||
| Each backend also has its own GitHub workflow, `nox-heavy-<backend>`, that must be triggered manually. |
Collaborator
There was a problem hiding this comment.
We could also try to have a single workflow, where you have to select from a dropdown which backend to use. That would avoid having to add more of these files in the future. I can work on that in a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Follow-up to #12985. Heavy integration targets are grouped by the backend service they need, so that each backend can be tested on its own in GitHub Actions:
heavy/<backend>alias instead ofheavy(rundecknow hasheavy/rundeck);heavy/still selects all of them;antsibull-nox.toml, taggedheavy-<backend>, replacing the session innoxfile.py;nox -Re ansible-test-integration-heavystill runs all of them;nox-heavy-<backend>, starting withnox-heavy-rundeck; the regularnoxworkflow excludes theheavytag;aliasesextra sanity check fails when aheavy/<backend>alias has no tagged session or no workflow.GitLab (#13005) is meant to be added as another backend.
AI (Claude) was used to assist with this contribution.
ISSUE TYPE
COMPONENT NAME
.github/workflows/nox-heavy-rundeck.yml
.github/workflows/nox.yml
antsibull-nox.toml
noxfile.py
tests/sanity/extra/aliases.py
tests/integration/targets/rundeck
ADDITIONAL INFORMATION
A
workflow_dispatchtrigger only becomes available once the workflow is in the default branch.nox-heavy-rundeckwas run in this PR with a temporarypull_requesttrigger, since removed: https://github.com/ansible-collections/community.general/actions/runs/41141268833🤖 Generated with Claude Code