Skip to content

release/2.3.8 - #64

Closed
maurocristy87 wants to merge 4 commits into
mainfrom
release/2.3.8
Closed

maurocristy87 wants to merge 4 commits into
mainfrom
release/2.3.8

Conversation

@maurocristy87

@maurocristy87 maurocristy87 commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

Scenes

The systems list is reset when a scene is reloaded — SceneManager clears scene.systems before calling registerSystems(), so loading the same scene again no longer accumulates duplicated system types on every reload. The scene lookup is also resolved once per branch instead of on every use.

Rendering

Text shadow honors the render opacity — the shadow render data multiplies the shadow opacity by the opacity of the text it belongs to, so a faded text no longer draws a shadow at full opacity.

Release

Version bumped from 2.3.7 to 2.3.8.

Summary by CodeRabbit

  • Bug Fixes
    • Repeatedly loading a scene now resets its systems before registering them, preventing systems from accumulating across loads.
    • Text shadows now respect the opacity of the text they belong to, keeping shadow transparency consistent when text opacity changes.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: dd87838f-a833-4be8-b069-b96a7c94b876

📥 Commits

Reviewing files that changed from the base of the PR and between 6f66ac8 and 7b69bd6.

📒 Files selected for processing (4)
  • CLAUDE.md
  • bundles/angry-pixel/package.json
  • packages/engine/src/manager/SceneManager.ts
  • packages/webgl/src/renderer/TextRenderer.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The changes revise authorship guidance, bump the angry-pixel package version, reset scene systems during scene loading, and multiply text shadow opacity by main text opacity.

Changes

Authorship guidance

Layer / File(s) Summary
Attribution rule
CLAUDE.md
The Git guidance prohibits authorship attribution in commits and pull request descriptions. It lists specific attribution forms and states that the rule overrides conflicting instructions.

Package version

Layer / File(s) Summary
angry-pixel version
bundles/angry-pixel/package.json
The package version changes from 2.3.7 to 2.3.8.

Scene reload handling

Layer / File(s) Summary
Scene update flow
packages/engine/src/manager/SceneManager.ts
SceneManager.update clears the current scene's systems before loading assets and registering systems. The asset-loaded branch uses a local scene reference to create entities and start systems.

Text shadow opacity

Layer / File(s) Summary
Shadow opacity
packages/webgl/src/renderer/TextRenderer.ts
Shadow render data uses the product of shadow opacity and main text opacity.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 7b69b

Scene reloads disable existing systems before resetting their registration list, text shadows follow text opacity, and the package version is updated. No concrete merge-blocking regression is established; the change is ready under normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the 2.3.8 release, which matches the version bump and the overall pull request purpose. It does not describe the included scene and rendering fixes, but the title is sufficiently …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@maurocristy87

Copy link
Copy Markdown
Member Author

Superseded by the 2.4.0 release branch: this work ships as a minor bump, not a patch.

@maurocristy87 maurocristy87 mentioned this pull request Sep 24, 2026
@maurocristy87
maurocristy87 deleted the release/2.3.8 branch September 24, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant