Skip to content

[TASK] Fix PHP 8.5 checks without platform overrides #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weakbit merged 1 commit into from
Oct 27, 2026
Merged

[TASK] Fix PHP 8.5 checks without platform overrides #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/tasks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
name: "php: ${{ matrix.php }} TYPO3: ${{ matrix.typo3 }}"
runs-on: ubuntu-latest
strategy:
fail-fast: true
fail-fast: false
max-parallel: 4
matrix:
php: [ '82', '83', '84', '85' ]
Expand All @@ -31,8 +31,10 @@ jobs:
restore-keys: |
${{ matrix.typo3 }}-${{ matrix.php }}-composer-
- run: git config --global --add safe.directory $GITHUB_WORKSPACE
- run: composer switchto${{ matrix.typo3 }} --ignore-platform-req=php+
- run: ./vendor/bin/grumphp run --ansi --no-interaction
- run: composer require "enshrined/svg-sanitize:~1.0.0" --dev --no-update --sort-packages --no-interaction
- run: composer switchto${{ matrix.typo3 }}
- name: Run all static checks
run: ./vendor/bin/grumphp run --no-ansi --no-interaction
- run: composer test
- name: Generate coverage report
if: matrix.php == '83' && matrix.typo3 == '14'
Expand Down
4 changes: 1 addition & 3 deletions Classes/Cache/Backend/LuceneCacheBackend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,7 @@ public function __construct(array $options = [])
public function set(string $entryIdentifier, string $data, array $tags = [], ?int $lifetime = null): void
{
// Lifetime of this cache entry in seconds. If NULL is specified, the default lifetime is used. "0" means unlimited lifetime.
if ($lifetime === null) {
$lifetime = $this->defaultLifetime;
}
$lifetime ??= $this->defaultLifetime;

if ($lifetime === 0) {
$lifetime = 9999999999;
Expand Down
2 changes: 0 additions & 2 deletions rector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
use PLUS\GrumPHPConfig\RectorSettings;
use Rector\Config\RectorConfig;
use Rector\Caching\ValueObject\Storage\FileCacheStorage;
use Rector\Set\ValueObject\SetList;
use Ssch\TYPO3Rector\TYPO311\v0\DateTimeAspectInsteadOfGlobalsExecTimeRector;

return static function (RectorConfig $rectorConfig): void {
Expand Down Expand Up @@ -40,7 +39,6 @@
DateTimeAspectInsteadOfGlobalsExecTimeRector::class,
RemoveExtraParametersRector::class,
RemoveUnusedPrivateMethodRector::class,
SetList::STRICT_BOOLEANS,

/**
* rector should not touch these files
Expand Down
Loading