-
Notifications
You must be signed in to change notification settings - Fork 11
fix: use cookie/urlParam-based fallback by default with redirect action #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tyiuhc
wants to merge
113
commits into
main
Choose a base branch
from
web/subdomain-redirect-default
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 106 commits
Commits
Show all changes
113 commits
Select commit
Hold shift + click to select a range
4a333ae
poc
tyiuhc ac9297d
simplify
tyiuhc 1707e1c
simplify
tyiuhc ed3151a
fix
tyiuhc 1edb608
fix
tyiuhc 7b3ecc3
Merge branch 'main' into web/subdomain-redirect-poc
tyiuhc e030327
fix for special case domains
tyiuhc 0c5ead6
fix tests
tyiuhc 0a45d29
fix lint
tyiuhc 0bc57bf
Merge branch 'main' into web/subdomain-redirect-poc
tyiuhc d4bdd83
Merge branch 'main' into web/subdomain-redirect-poc
tyiuhc 2b64028
Merge branch 'main' into web/subdomain-redirect-poc
tyiuhc cafc03c
fix marketing cookie logic
tyiuhc 39ae94e
feat: support new page triggers - element appeared, element visible, …
tyiuhc ca355c0
add comment
tyiuhc 49b73de
mutation manager should directly update state
tyiuhc 6b9935c
add try-catch for initialization
tyiuhc d0c9aeb
feat: add user_interaction trigger (#243)
tyiuhc 9a16d83
feat: add exit_intent trigger (#246)
tyiuhc f910b80
feat: add analytics_event trigger (#245)
tyiuhc 212086b
feat: add time_on_page trigger (#242)
tyiuhc 84b011e
feat: add scolled_to trigger (#244)
tyiuhc e42d012
update per comments
tyiuhc 0d15f3f
fix delimiter and refactor delegation
tyiuhc 62e2e4a
delimiter fix, fix hover checks
tyiuhc 6f79133
simplify clean up logic
tyiuhc 9e935bc
reduce scope of applyVariants to experiments relevant to the trigger …
tyiuhc c8abd74
refactor setupPageObjectSubscriptions
tyiuhc d0be2f9
fix test mocking, fix lint
tyiuhc 8ee7c62
refactor test mocks
tyiuhc 1360c8d
update element_appeared messaging
tyiuhc e25d3b7
catch querySelectorAll error
tyiuhc 3bf52ce
evaluation trigger_value for conditions
tyiuhc ae805d0
reset states upon url change
tyiuhc c18ed81
fix offset logic
tyiuhc 06b4821
fix hover logic
tyiuhc 5628a40
add comment
tyiuhc 6942db7
update analytics_event props
tyiuhc 7442bd0
persist manually triggered page objects
tyiuhc 2d94113
factor out utils, early return for publishers if not required
tyiuhc 8c3a3cb
nit: update util desc
tyiuhc c5da5a5
update active to toggleManualPageObject
tyiuhc b3aba31
make trackEvent private
tyiuhc 8a6328b
simplify comments
tyiuhc 1449576
fix toggleManualPageObject
tyiuhc 4f1c5ff
fix scrolled_to percentage when scroll height is 0
tyiuhc 5f7dddc
Merge branch 'main' into web/page-triggers-1
tyiuhc 0d77c6c
persist analytics_event state
tyiuhc 890e7b4
update click with minThreshold
tyiuhc cf658e6
fix exit_intent timeout logic
tyiuhc 9489888
fix handleinject scoping
tyiuhc 0dbed0d
Merge branch 'main' into web/page-triggers-1
tyiuhc 0680053
only apply variant actions if page objects are updated
tyiuhc c0164d9
fix lint
tyiuhc 422ad78
scope preview variants to trigger
tyiuhc 2561c8a
do not trigger url_change when url is the same
tyiuhc c60f40d
use globalScope.setTimeout
tyiuhc 6db28c8
Merge branch 'main' into web/page-triggers-1
tyiuhc bfdd135
Merge branch 'main' into web/subdomain-redirect-poc
tyiuhc 7ac74ea
fix preview filtering
tyiuhc bb807d4
buffer events before initialization completes
tyiuhc 4eabeaf
fix itest
tyiuhc a4fe72c
fix preview for event tracked
tyiuhc 8a00071
fix: use querySelectorAll to check all matched elements
tyiuhc 5c3fccf
Merge branch 'main' into web/page-triggers-1
tyiuhc 88e19f7
Merge branch 'web/page-triggers-1' into web/subdomain-redirect-poc
tyiuhc 432eba1
Merge branch 'main' into web/subdomain-redirect-poc
tyiuhc 407c422
merge main
tyiuhc 7267171
Merge branch 'main' into web/subdomain-redirect-poc
tyiuhc e384d41
Merge branch 'main' into web/subdomain-redirect-poc
tyiuhc e1f84cc
Merge branch 'main' into web/subdomain-redirect-poc
ansonchen2 2b16d3a
Merge branch 'main' into web/subdomain-redirect-poc
ansonchen2 df3f4e9
Merge branch 'main' into web/subdomain-redirect-poc
ansonchen2 6deb5d2
Merge branch 'main' into web/subdomain-redirect-poc
ansonchen2 0d9f91f
Merge branch 'main' into web/subdomain-redirect-poc
ansonchen2 bea05de
Merge branch 'main' into web/subdomain-redirect-poc
tyiuhc 3759d4a
Merge branch 'web/subdomain-redirect-poc' of github.com:amplitude/exp…
tyiuhc fa2498b
fix(subdomain): add await for storage (#307)
kwliou 8c48da0
Merge branch 'main' into web/subdomain-redirect-poc
tyiuhc f9b78d5
Merge branch 'web/subdomain-redirect-poc' of github.com:amplitude/exp…
tyiuhc d977847
fix tests
tyiuhc 42ced13
fix lint
tyiuhc a9015ee
Merge branch 'main' into web/subdomain-redirect-poc
tyiuhc a70fc95
Merge branch 'main' into web/subdomain-redirect-poc
tyiuhc 5fef8be
add config and use cookie as fallback
tyiuhc 0369e80
fix eTLD logic and tests
tyiuhc 8f2ff01
fix merge
tyiuhc 016853c
nit: update desc
tyiuhc 5998caa
fix: await async applyVariants and fireStoredRedirectImpressions call…
tyiuhc 4ad7e74
fix lint
tyiuhc 2829700
fix: include impression data in url as fallback for cross-subdomain r…
tyiuhc 8963f96
fix catch
tyiuhc 20809cc
Merge branch 'main' into web/subdomain-redirect-poc
tyiuhc abaa7a0
fix lint
tyiuhc 736291c
fix comment
tyiuhc 0b7607a
Merge branch 'main' into web/subdomain-redirect-poc
tyiuhc ef45109
remove antiflicker after local var application
tyiuhc d4a7923
set defaults
tyiuhc d50f284
fix(experiment-tag): pre-register cleaned URL before replaceState to …
tyiuhc ce31466
feat(experiment-tag): enable url and cookie redirect encoding by default
tyiuhc 16a9c66
chore: merge main into web/subdomain-redirect-poc and fix redirect te…
tyiuhc 1c05706
Merge branch 'web/subdomain-redirect-poc' into web/subdomain-redirect…
tyiuhc 403ffcc
fix debounce, get tld
tyiuhc a191943
Merge branch 'web/subdomain-redirect-poc' into web/subdomain-redirect…
tyiuhc 9e6eeaa
rge branch 'main' into web/subdomain-redirect-default
tyiuhc 083f79e
fix(experiment-tag): prevent anti-flicker CSS removal during redirect…
tyiuhc 27bd6d0
fix(experiment-tag): use isRedirecting flag instead of never-resolvin…
tyiuhc c3a3878
fix(experiment-tag): keep anti-flicker during redirect in bootstrap
tyiuhc 6c95b66
fix(experiment-tag): gate preview-path anti-flicker teardown on isRed…
tyiuhc 1c6c166
Merge remote-tracking branch 'origin/main' into web/subdomain-redirec…
tyiuhc 408eb8f
fix(spa-router): allow interceptor to navigate to external URLs (#353)
kwliou a7ac131
Merge branch 'main' into web/subdomain-redirect-default
tyiuhc 6cdd9f3
Merge branch 'web/subdomain-redirect-default' of github.com:amplitude…
tyiuhc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.