fix(session-replay-react-native): pass null deviceId through to native SDKs - #1962
Draft
aliaksandr-kazarez wants to merge 1 commit into
Draft
fix(session-replay-react-native): pass null deviceId through to native SDKs#1962aliaksandr-kazarez wants to merge 1 commit into
aliaksandr-kazarez wants to merge 1 commit into
Conversation
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
string | null) and keepnullmeaning clear/unset.nullto an empty string in Android setup andsetDeviceId; pass it directly to session-replay-android.setDeviceIdbridge parameter nullable end to end.Blocks on
[0.29.0,0.30.0). If fix(plugins): update timing of sending batches of session replay events #471 ships under a different version, update that range before landing.Test plan
pnpm exec jest --runInBand --testPathPattern='\\.test\\.(ts|tsx)$'(62 tests passed)pnpm typecheckpnpm buildinpackages/session-replay-react-nativetest/session-replay.test.ts:app:compileDebugKotlincurrently stops at dependency resolution because Maven Central has nocom.amplitude:session-replay-androidversion in[0.29.0,0.30.0)yet. Re-run after fix(plugins): update timing of sending batches of session replay events #471 is published.Posted automatically with Cursor. LLMs make mistakes — please verify before acting.