fix(browser): normalize empty instance names - #1956
Draft
Mercy811 wants to merge 1 commit into
Draft
Conversation
Route Browser Analytics, Experiment, and identity updates through the same canonical connector. Preserve explicit custom instance names. Refs SDKW-59.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
undefinedand exactly''resolve to$default_instance.BrowserConfig.Why
Browser Analytics could bind identity and its event receiver to an empty-string connector while Experiment resolved the same input to
$default_instance. The SDKs would initialize successfully but silently lose identity synchronization and Experiment exposure-event forwarding.PR #1944 fixed the React Native occurrence that exposed this issue. This PR applies the corresponding Browser/Core fix tracked by SDKW-59.
Safety and storage impact
packages/analytics-browsersearch found that the configured instance name only routes in-memory connector activity.createInstance(instanceName)registry is separate and is not changed.globalThis.analyticsConnectorInstances.instanceName; no persistent storage migration is involved.Validation
Ticket: https://linear.app/amplitude/issue/SDKW-59/normalize-empty-instancename-across-browser-analytics-and-experiment