Repository navigation
Sortable agent context menu (requires amidaware/tacticalrmm#2564) - #62
Open
christian-wr wants to merge 4 commits into
Open
christian-wr wants to merge 4 commits into
christian-wr wants to merge 4 commits into
Conversation
With no own layout, the Preferences editor now shows the company layout instead of the effective one, so 'Use company default' and 'Reset to default' followed by an edit start from the company layout. Requires agent_menu_company_layout from dashinfo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Frontend for the sortable agent context menu. Requires amidaware/tacticalrmm#2564, which adds the layout fields and the dashinfo keys.
vuedraggable, already a dependency)What changes
src/core/agentmenu/items.ts: registry of the 19 top-level entries in today's order. "Close" always stays last and is not part of it.src/core/agentmenu/resolve.ts: pure functions.AgentActionMenu.vue: the existing items render inside<template v-for="id in menuIds">, each behindv-if="id === '…'". Their markup, sub-menus and existing conditions (Reporting integrations,:disablefor URL actions and favourites) are unchanged. Most of the diff is re-indentation;git diff -wshows the real change.settingsobject and uses the shared Save button. That way a Save on another tab can never overwrite the menu layout with stale data.{}, so later company changes still reach them. The editor shows the company layout until the user changes something.agentMenuLayout,agentMenuAllowUser,agentMenuUserLayout,agentMenuCompanyLayout, all filled fromgetDashInfo.Tests
quasar buildpasses.vue-tscreports the same 39 errors asdevelop, none in changed code.