Repository navigation
Conversation
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API side is in the tacticalrmm PR. This is the form, the table, and the toast.
You can put Jinja expressions on the schedule. Same variables as the template. Empty means always run. Changing the template clears the list so you don't keep predicates that belonged to the old one.
The table shows last status and how many conditions are set. A manual run that skipped used to say it ran and then send you to history. It didn't write a history row. That toast now says it skipped.
This will not work against an unpatched API.
/run/still looks like success if the backend never returnsskipped.How I tested
False. Skip toast, Last Status skipped, no historyTrue. Success again{% for %}is rejected on saveundefined_nameerrors, it does not skip