Repository navigation
Conversation
Signed-off-by: Rio Yu <52408936+rioyu123@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: None.
Description of changes:
save_job_checkpointandsave_job_resultopened the output file with"w"before serializing the data. If serialization failed, the existing file was already truncated. If no file existed, an empty one was left behind.For
results.jsonthis also blocked recovery: every later save tried to load the empty file and failed, even with valid data.This change builds the complete JSON string before opening the file. Serialization failures leave existing data untouched and do not create a new file. The file format and public API are unchanged. This does not make writes atomic or protect against errors during the write itself.
Testing done:
tox -e unit-tests -- -n 4passes (3,504 passed, 131 xfailed).tox -e linters_check,type-check,docspasses. The documentation build completes with warnings.tox -e coverage-checkpasses at 100%.Merge Checklist
General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.