fix: silence noisy go-sql-driver mysql logging - #827
Open
ChrisJr404 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
dbmate up --waitruns before the database is ready, go-sql-driver logs its own error lines straight to stderr, so the console fills up with[mysql] packets.go:37: unexpected EOFbefore the "Waiting for database" dots even show up. dbmate already reports the real connection error itself, and the other drivers don't spew this, so the driver's logging is just noise here.This sets a
NopLoggeron the mysql config we build for our own connections. It stays scoped to dbmate's connections rather than touching the driver's global logger, so it won't silence go-sql-driver for anyone using dbmate as a library.Part of #516 (the console spam that was asked to be fixed first). The
--wait-intervalflag from that issue is already covered by #803, so I kept this separate.