feat(Supporting Membership): replace checkbox with yearly records (LAN-910) - #340
Merged
Conversation
…N-910) Replace the `is_supporting_member` checkbox on **LANDA Member** with a **Supporting Membership** DocType keyed by member and year. Add mutual exclusion validation with **Yearly Fishing Permit**, update member data import and the current member data report, and schedule daily status updates.
Contributor
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains. No blocking failure remains.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…check Treat active Supporting Membership records like Yearly Fishing Permits when determining magazine eligibility, so Fördermitglieder are not excluded from mailing when they have no permit.
Mirror the Yearly Fishing Permit bulk-create workflow so Vereinsnutzer can create supporting memberships for multiple members at once.
other unrelated changes are auto-generated
… (LAN-910) The check for an active Yearly Fishing Permit only ran when the Supporting Membership had the status "Active", that is, when its year was the current year. The opposite check in Yearly Fishing Permit ran for all Supporting Memberships, because member_has_active_supporting_membership does not filter by status. The rule was therefore order-dependent for the next year. A Yearly Fishing Permit followed by a Supporting Membership was allowed, while the reverse order was blocked. Run the check for all statuses to make both directions symmetric. Also wrap the save in update_supporting_membership_statuses, because the scheduled task now fails on legacy records that hold both documents for the same year. One invalid record stopped the whole loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the
is_supporting_membercheckbox on LANDA Member with a Supporting Membership DocType keyed by member and year. Add mutual exclusion validation with Yearly Fishing Permit, update Member Data Import and the "Current Member Data" report, and schedule yearly status updates.Existing data is deliberately dropped. Data migration is not desired.
To do: