Skip to content

fix: prevent EBICS batch imports from being skipped when camt.054 download is disabled - #422

Open
barredterra with Copilot wants to merge 7 commits into
version-16-hotfixfrom
copilot/fix-import-skipped-forever
Open

fix: prevent EBICS batch imports from being skipped when camt.054 download is disabled#422
barredterra with Copilot wants to merge 7 commits into
version-16-hotfixfrom
copilot/fix-import-skipped-forever

Conversation

Copilot AI commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

When batch splitting is enabled but camt.054 downloads are disabled, unresolved batch entries were treated as transient failures and the main statement import was skipped indefinitely.

  • Batch import behavior

    • Keep sub-transaction splitting controlled by Split Batch Transactions.
    • Treat an unresolved batch as transient only when Download Batch Transactions is enabled, so a later camt.054 download can resolve it.
    • When downloads are disabled and sub-transactions are unavailable, import the batch as a single Bank Transaction.
  • Regression coverage

    • Verifies split and download settings are passed independently.
    • Covers importing unresolved batches as a single transaction when downloads are disabled.
    • Covers retaining the skip-and-retry path when downloads are enabled.
  • Fixes Import skipped forever when split is on but download_batch_transactions is off #421

Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix import skipping issue when split is on and download_batch_transactions is off Prevent EBICS batch imports from being skipped when camt.054 download is disabled Aug 7, 2026
Copilot AI requested a review from barredterra August 7, 2026 10:50
Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com>
@barredterra
barredterra marked this pull request as ready for review August 7, 2026 12:06
@greptile-apps

greptile-apps Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Reviews (5): Last reviewed commit: "style: format with ruff" | Re-trigger Greptile

Comment thread banking/ebics/test_utils.py
Comment thread banking/ebics/utils.py Outdated
Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com>
Copilot AI requested a review from barredterra August 15, 2026 17:18
@barredterra barredterra changed the title Prevent EBICS batch imports from being skipped when camt.054 download is disabled fix: prevent EBICS batch imports from being skipped when camt.054 download is disabled Aug 15, 2026
@barredterra

Copy link
Copy Markdown
Member

@Mergifyio backport version-15-hotfix

@mergify

mergify Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

backport version-15-hotfix

🟠 Waiting for conditions to match

Details
  • merged [📌 backport requirement]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import skipped forever when split is on but download_batch_transactions is off

2 participants