Skip to content
This repository was archived by the owner on Mar 25, 2022. It is now read-only.

Changing <a name=...> to <em id=...></em> for correct html5 validation #5

Open
sveinns wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Changing <a name=...> to <em id=...></em> for correct html5 validation #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22c0255
TODO: Use id attribute for HTML5 compatibility.
Aug 11, 2011
c1743d6
Corrected file and tests relying on code.
Aug 14, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/Pod/PseudoPod/HTML.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,8 @@ sub end_R { $_[0]{'scratch'} .= '</em>' }
sub start_U { $_[0]{'scratch'} .= '<font class="url">' if $_[0]{'css_tags'} }
sub end_U { $_[0]{'scratch'} .= '</font>' if $_[0]{'css_tags'} }

sub start_Z { $_[0]{'scratch'} .= '<a name="' }
sub end_Z { $_[0]{'scratch'} .= '">' }
sub start_Z { $_[0]{'scratch'} .= '<em id="' }
sub end_Z { $_[0]{'scratch'} .= '"></em>' }

sub emit {
my($self, $nowrap) = @_;
Expand Down
6 changes: 3 additions & 3 deletions t/beginend.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ is($results, <<'EOHTML', "a sidebar with a Z<> entity");
<blockquote>
<h3>Title Text</h3>

<p>This is the text of the <a name="strange"> sidebar.</p>
<p>This is the text of the <em id="strange"></em> sidebar.</p>

</blockquote>

Expand Down Expand Up @@ -175,7 +175,7 @@ F<sample.gif>
EOPOD

is($results, <<'EOHTML', "a figure with a Z<> tag included.");
<p><a name="figure1"> <img src="sample.gif"></p>
<p><em id="figure1"></em> <img src="sample.gif"></p>



Expand All @@ -192,7 +192,7 @@ F<sample.gif>
EOPOD

is($results, <<'EOHTML', "a figure with a caption.");
<p><a name="figure1"> <img src="sample.gif"></p>
<p><em id="figure1"></em> <img src="sample.gif"></p>

<p><em>This is a sample figure</em></p>

Expand Down
14 changes: 8 additions & 6 deletions t/html.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,16 +264,16 @@ $html = '<p>A plain paragraph with a <font class="url">'

is($results, $html, "URL entity in a paragraph");

initialize($parser, $results);
$parser->parse_string_document(<<'EOPOD');
TODO: {
local $TODO = "Cross references should produce an 'id' property in a structural element.";
initialize($parser, $results);
$parser->parse_string_document(<<'EOPOD');
=pod

A plain paragraph with a Z<crossreferenceendpoint>.
EOPOD
is($results, <<"EOHTML", "Link anchor entity in a paragraph");
<p>A plain paragraph with a <a name="crossreferenceendpoint">.</p>

EOHTML
like($results, qr/id="crossreferenceendpoint"/, "Link anchor entity in a paragraph");
}

initialize($parser, $results);
$parser->parse_string_document(<<'EOPOD');
Expand Down Expand Up @@ -389,6 +389,8 @@ EOPOD
}




done_testing();

######################################
Expand Down
2 changes: 1 addition & 1 deletion t/table.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ EOPOD
is($results, <<'EOHTML', "a table with a Z<> tag inside");
<table>

<p><a name="table1"></p>
<p><em id="table1"></em></p>

<tr>

Expand Down