fix: parse --preemptible flag in Beaker submit scripts#1742
Open
Chessing234 wants to merge 2 commits into
Open
fix: parse --preemptible flag in Beaker submit scripts#1742Chessing234 wants to merge 2 commits into
Chessing234 wants to merge 2 commits into
Conversation
argparse type=bool treats any string as True, so --preemptible False still submitted preemptible jobs. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the --preemptible command-line argument in both scripts/submit_dpo_job.py and scripts/submit_finetune_job.py to use action=argparse.BooleanOptionalAction instead of type=bool. This correctly resolves issues with boolean parsing in argparse. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--preemptiblefromtype=booltoBooleanOptionalActionin finetune and DPO submit scriptstype=boolin argparse treats any non-empty string as True, so--preemptible Falsestill set preemptible=True in the Beaker job config.Test plan
python scripts/submit_finetune_job.py --no-preemptible --helpand confirm flag parsespreemptible: falsewhen--no-preemptibleis passedMade with Cursor