fix(deps): drop tar override that broke the publish pipeline#2550
Closed
jakehobbs wants to merge 1 commit into
Closed
fix(deps): drop tar override that broke the publish pipeline#2550jakehobbs wants to merge 1 commit into
jakehobbs wants to merge 1 commit into
Conversation
The tar override forced lerna 8.2.4 onto tar 7, whose API is incompatible with lerna's packDirectory (TypeError: Cannot read properties of undefined (reading 'create')), breaking the publish pipeline. Reverts tar to its prior resolution; js-yaml overrides are retained. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the release/publish workflow by removing the pnpm override that forced lerna@8.2.4 to resolve to an incompatible tar@7 API, restoring the prior multi-version tar resolution so lerna publish can pack and publish successfully.
Changes:
- Removed the
tar@<7.5.18pnpm override frompackage.jsonand the lockfile. - Updated
pnpm-lock.yamlto reflecttarresolving back to the pre-override set (6.2.1,7.2.0,7.5.21) across the dependency graph.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Drops the tar override while retaining the js-yaml overrides. |
| pnpm-lock.yaml | Removes the tar override and updates resolved tar versions/entries to restore lerna compatibility. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Comments suppressed due to low confidence (1)
pnpm-lock.yaml:7152
tar@7.2.0is also marked deprecated with a security-vulnerability warning. If this version is only present due to a specific transitive pin (e.g.,prool), consider whether that dependency can be upgraded/replaced to move off the deprecatedtarline.
Comment on lines
+7144
to
+7147
| tar@6.2.1: | ||
| resolution: {integrity: sha512-DZ4yORTwrbTj/7MZYq2w+/ZFdI6OZ/f9SFHR+71gIVUZhOQPHzVCLpvRnPgyaMpfWxxk/4ONva3GQSyNIKRv6A==} | ||
| engines: {node: '>=10'} | ||
| deprecated: Old versions of tar are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting i@izs.me |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
tar@<7.5.18pnpm override added in #2549. That override forcedlerna@8.2.4ontotar@7, whose API is incompatible with lerna'spackDirectory:lerna publishbumps versions, commits, and tags before packing/publishing, so the v5.0.8 version bump + git tags landed onmain, but the actualnpm publishnever ran — leaving npm on 5.0.7 with a dangling 5.0.8 tag.Change
tar@<7.5.18.tarreverts to its prior resolution (6.2.1 / 7.2.0 / 7.5.21) — the same set that shipped 5.0.7 successfully.js-yamloverrides (3.15.0/4.3.0) are retained — they were not implicated in the failure (the CI build steps passed; only lerna's pack step crashed on tar).node-tarshipped no 6.x-compatible patch for the range lerna needs, so there is notarbump that both satisfies the dependency-hygiene goal and keeps lerna 8 working. Moving lerna'starforward would require a lerna v9 major upgrade, which should be evaluated on its own rather than bundled into a lockfile change.Verification
pnpm install --frozen-lockfilepasses on Node 22.20.0.tarback to the resolution that published 5.0.7;js-yamlremains on 3.15.0 / 4.3.0.🤖 Generated with Claude Code
PR-Codex overview
This PR focuses on updating the package dependencies in
package.jsonandpnpm-lock.yaml, particularly thetarpackage and its versions, while also adding new entries for several packages with their respective resolutions and engine requirements.Detailed summary
tarpackage versions from7.5.21to6.2.1and7.2.0.chownr@2.0.0andfs-minipass@2.1.0.minipass@5.0.0andmkdirp@1.0.4.tarversions.