Skip to content

fix(deps): drop tar override that broke the publish pipeline#2550

Closed
jakehobbs wants to merge 1 commit into
mainfrom
jake/revert-tar-override
Closed

fix(deps): drop tar override that broke the publish pipeline#2550
jakehobbs wants to merge 1 commit into
mainfrom
jake/revert-tar-override

Conversation

@jakehobbs

@jakehobbs jakehobbs commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

What

Removes the tar@<7.5.18 pnpm override added in #2549. That override forced lerna@8.2.4 onto tar@7, whose API is incompatible with lerna's packDirectory:

lerna ERR! TypeError: Cannot read properties of undefined (reading 'create')
lerna ERR!     at packDirectory (.../node_modules/lerna/dist/index.js:6231:39)

lerna publish bumps versions, commits, and tags before packing/publishing, so the v5.0.8 version bump + git tags landed on main, but the actual npm publish never ran — leaving npm on 5.0.7 with a dangling 5.0.8 tag.

Change

  • Drop tar@<7.5.18. tar reverts to its prior resolution (6.2.1 / 7.2.0 / 7.5.21) — the same set that shipped 5.0.7 successfully.
  • The js-yaml overrides (3.15.0 / 4.3.0) are retained — they were not implicated in the failure (the CI build steps passed; only lerna's pack step crashed on tar).

node-tar shipped no 6.x-compatible patch for the range lerna needs, so there is no tar bump that both satisfies the dependency-hygiene goal and keeps lerna 8 working. Moving lerna's tar forward would require a lerna v9 major upgrade, which should be evaluated on its own rather than bundled into a lockfile change.

Verification

  • pnpm install --frozen-lockfile passes on Node 22.20.0.
  • tar back to the resolution that published 5.0.7; js-yaml remains on 3.15.0 / 4.3.0.

🤖 Generated with Claude Code


PR-Codex overview

This PR focuses on updating the package dependencies in package.json and pnpm-lock.yaml, particularly the tar package and its versions, while also adding new entries for several packages with their respective resolutions and engine requirements.

Detailed summary

  • Updated tar package versions from 7.5.21 to 6.2.1 and 7.2.0.
  • Added new packages:
    • chownr@2.0.0 and fs-minipass@2.1.0.
    • minipass@5.0.0 and mkdirp@1.0.4.
  • Specified engine requirements for several packages.
  • Included deprecation warnings for older tar versions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

The tar override forced lerna 8.2.4 onto tar 7, whose API is
incompatible with lerna's packDirectory (TypeError: Cannot read
properties of undefined (reading 'create')), breaking the publish
pipeline. Reverts tar to its prior resolution; js-yaml overrides are
retained.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 24, 2026 16:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the release/publish workflow by removing the pnpm override that forced lerna@8.2.4 to resolve to an incompatible tar@7 API, restoring the prior multi-version tar resolution so lerna publish can pack and publish successfully.

Changes:

  • Removed the tar@<7.5.18 pnpm override from package.json and the lockfile.
  • Updated pnpm-lock.yaml to reflect tar resolving back to the pre-override set (6.2.1, 7.2.0, 7.5.21) across the dependency graph.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
package.json Drops the tar override while retaining the js-yaml overrides.
pnpm-lock.yaml Removes the tar override and updates resolved tar versions/entries to restore lerna compatibility.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file
Comments suppressed due to low confidence (1)

pnpm-lock.yaml:7152

  • tar@7.2.0 is also marked deprecated with a security-vulnerability warning. If this version is only present due to a specific transitive pin (e.g., prool), consider whether that dependency can be upgraded/replaced to move off the deprecated tar line.

Comment thread pnpm-lock.yaml
Comment on lines +7144 to +7147
tar@6.2.1:
resolution: {integrity: sha512-DZ4yORTwrbTj/7MZYq2w+/ZFdI6OZ/f9SFHR+71gIVUZhOQPHzVCLpvRnPgyaMpfWxxk/4ONva3GQSyNIKRv6A==}
engines: {node: '>=10'}
deprecated: Old versions of tar are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting i@izs.me
@jakehobbs

Copy link
Copy Markdown
Collaborator Author

Superseded by #2551, which upgrades lerna to v9 — that fixes the pack-step crash and keeps the tar override (so alert #524 stays closed), instead of reverting it. Reopen this if the v9 upgrade needs to be held and we want to unblock the release with the revert instead.

@jakehobbs jakehobbs closed this Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants