docs(networking): add Kube-OVN underlay multicast guide - #972
Conversation
fanzy618
left a comment
There was a problem hiding this comment.
Review findings
[P1] Require an IPv4 subnet
configure_underlay_multicast.mdx:15-18 describes IPv4 multicast, but the prerequisites only require an Underlay subnet and do not require spec.protocol: IPv4.
Kube-OVN allocates multicast querier addresses according to the subnet protocol. For IPv6/Dual, status.mcastQuerierIP is not an IPv4-only value (Dual can contain both addresses), while the OVN setting uses mcast_ip4_src. Please add an explicit IPv4 protocol prerequisite and clarify that IPv6/Dual subnets are not covered by this guide.
[P2] Add the disable procedure
The PR description says the guide covers enabling, verifying, and disabling multicast snooping, but the final document ends after the enable/verify steps and contains no disable procedure. Please add the web-console or CLI steps, for example:
kubectl patch subnet <subnet-name> --type=merge \\
-p '{"spec":{"enableMulticastSnoop":false}}'This is also needed to document releasing the multicast querier IP/MAC.
Fact-check notes
I verified that enableMulticastSnoop, status.mcastQuerierIP, and status.mcastQuerierMAC are present in Kube-OVN, and that enabling creates the querier while disabling releases its IP/MAC. The ACP version: 4.2 mapping should ideally include an ACP 4.2 release/Jira reference because it cannot be established from the upstream Kube-OVN source alone.
|
Addressed both review items in commit 5bf4526:
Validation completed successfully: |
5bf4526 to
3672e0d
Compare
Summary
Validation
yarn lint: 0 errors and 0 warningsyarn build: passedgit diff --check: passedThe local build reports that Node.js 20.18.0 is below Rspack recommended 20.19+, but the lint and build commands both completed successfully.
Jira: https://jira.alauda.cn/browse/ACP-54443