Lint pass. - #4
Open
ssteinbach wants to merge 28 commits into
Open
Conversation
…demySoftwareFoundation#381) * add test for -m none in otiocat.
* Added nested_example.otio sample data
* Fix AAF extact start
…ation#386) * Hide the data member of SerializableObject * Expose data() on unknown schema instead. * Hide update() method.
* Use a clip's parent Track kind to determine if we're dealing with a audio clip or not. Create a blank mediaproc for audio files to avoid no image warnings in RV.
…reFoundation#397) * Add code printing a helpful message if pip or setuptools is out of date. * Float the versions of dependencies rather than explicitly pin them. * Lock to pyside2 5.x
…reFoundation#396) Switched from using pyaaf, to pyaaf2, which is a pure python reimplementation of the AAF library. This switch was made in order to make building & installing this easier (many people have trouble getting the AAF libraries to work) and to provide more flexibility into the future. There are some subtle differences in the AAF metadata that the adapter places into the resulting OTIO, but this seems harmless. Performance is not as good as it was before, but we hope that we will be better able to profile and optimize this after this switch is complete. The only outstanding issue that could prevent this from being part of an upcoming OTIO release, is that the pyaaf2 install is done via a git clone from the master branch of pyaaf2. Once the next release of pyaaf2 comes out, we can switch to a regular pip install via pypi (in a future PR to OTIO). Thanks @freesonluxo and @shahbazk8194 for making this change!
* Make RationalTime immutable. * Make TimeRange immutable. * Fix bugs related to immutable time ranges. * Fix the clamped function (+ unit test). * Fix in the TimeRange constructor. - Now, if you only provide start_time or duration (not both), the constructor will try and read the rate for the default-constructor created other field from the one you provided - This revealed a bug in one of the files in the unit test suite, which had RV sources with an FPS of 1 * Add unit tests for immutability and += when self.rate > other.rate.
If you attempt to add an object to a composition, but that object already has a parent, an exception is now raised. You need to remove the object from it's old parent before adding it to the new one.
…Foundation#400) Please use deepcopy() instead of copy().
…on#401) If you ask for the trimmed_range_in_parent() for a clip that is completely trimmed out, then it returns None.
* Fix: wrong type for "hooks" * Fix: _json_path is not set for hook_scripts * Fix: manifest extend() does not include hooks / hook_scripts * Fix: added missing hook to tutorial sample code
ssteinbach
force-pushed
the
alatdneg-bisect_optimization
branch
from
December 22, 2018 01:00
92b9845 to
157c9ad
Compare
…m Timecode Mobs (AcademySoftwareFoundation#410) Co-authored-by: Freeson Wang <freeson@pixar.com>
- Also implement child_at_time using the _bisect functions.
ssteinbach
force-pushed
the
alatdneg-bisect_optimization
branch
from
February 7, 2019 22:22
157c9ad to
fd8e46a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the lint errors. Sorry about the delay on that! Thanks again for your help.