Skip to content

product_profile: only write modified field to avoid useless field recompute #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sebastienbeau wants to merge 2 commits into
base: 14.0-fix-product-profile
Choose a base branch
from
Open

product_profile: only write modified field to avoid useless field recompute #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e72295c
product_profile: only write modified field to avoid useless field rec…
sebastienbeau Oct 24, 2022
9e4e7b6
product_profile: fix create multi
sebastienbeau Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 26 additions & 9 deletions product_profile/models/product_profile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,17 +95,33 @@ def write(self, vals):

def _refresh_products_vals(self):
"""Reapply profile values on products"""
fnames = [
fname
for fname in self.env["product.product"]._get_profile_fields()
if not fname.startswith(PROF_DEFAULT_STR)
]
for rec in self:
products = self.env["product.product"].search([("profile_id", "=", rec.id)])
if products:
_logger.info(
" >>> %s Products updating after updated '%s' pro"
"duct profile" % (len(products), rec.name)
)
data = products._get_vals_from_profile(
{"profile_id": rec.id}, ignore_defaults=True
)
products.write(data)
for product in products:
# Only write field that have changed to avoid
# useless trigger of computed fields
vals = {}
for fname in fnames:
if product[fname] != rec[fname]:
vals.update(
{
fname: product._fields[fname].convert_to_write(
rec[fname], product
)
}
)
if vals:
product.write(vals)

@api.model
def check_useless_key_in_vals(self, vals, key):
Expand Down Expand Up @@ -210,11 +226,12 @@ def _onchange_from_profile(self):
except Exception as e:
raise UserError(format_except_message(e, field, self))

@api.model
def create(self, vals):
if vals.get("profile_id"):
vals.update(self._get_vals_from_profile(vals, ignore_defaults=False))
return super().create(vals)
@api.model_create_multi
def create(self, vals_list):
for vals in vals_list:
if vals.get("profile_id"):
vals.update(self._get_vals_from_profile(vals, ignore_defaults=False))
return super().create(vals_list)

def write(self, vals):
profile_changed = vals.get("profile_id")
Expand Down