fix(inkless:consolidation): recover a switched consolidated leader after local-log loss#673
Merged
Merged
Conversation
Contributor
Author
|
Reopened #653 as it disappeared after a faulty rebase of the base branch. |
viktorsomogyi
force-pushed
the
svv/ts-unification-consolidation-start-fix
branch
from
b767198 to
7118217
Compare
viktorsomogyi
force-pushed
the
svv/ts-unification-recover-leader
branch
from
b225b4f to
5bb36f0
Compare
Base automatically changed from
svv/ts-unification-consolidation-start-fix
to
main
June 29, 2026 13:56
…ter local-log loss A leader that comes up below the seal with an empty local log (a full local-storage wipe / disaster recovery where the controller, whose metadata survived, elects a replica that came back empty) has no peer to replicate the classic prefix from -- that prefix lives only in the remote tier. The ConsolidationReconciler now starts consolidation for such a leader (when remote storage is enabled) instead of retrying forever, so the fetcher lands below the diskless WAL start, hits OFFSET_MOVED_TO_TIERED_STORAGE, and rebuilds the leader-epoch cache and producer snapshot from remote. Co-authored-by: Cursor <cursoragent@cursor.com>
viktorsomogyi
force-pushed
the
svv/ts-unification-recover-leader
branch
2 times, most recently
from
c551884 to
89f76e2
Compare
jeqo
previously approved these changes
Jun 29, 2026
jeqo
left a comment
jeqo
left a comment
Contributor
There was a problem hiding this comment.
LGTM, left a couple of minor comments to improve observability and align test case names.
jeqo
reviewed
Jun 29, 2026
Comment on lines
+90
to
+91
| val isConsolidating = inklessMetadataView.isConsolidatingDisklessTopic(tp.topic) || | ||
| (inklessMetadataView.isDisklessTopic(tp.topic) && partition.log.exists(_.remoteLogEnabled())) |
Contributor
There was a problem hiding this comment.
just a note for future work: this can be collapsed to isDisklessTopic once the switch enables remote.storage.enable atomically as suggested here
…after local-log loss
jeqo
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A leader that comes up below the seal with an empty local log (a full local-storage wipe / disaster recovery where the controller, whose metadata survived, elects a replica that came back empty) has no peer to replicate the classic prefix from -- that prefix lives only in the remote tier. The ConsolidationReconciler now starts consolidation for such a leader (when remote storage is enabled) instead of retrying forever, so the fetcher lands below the diskless WAL start, hits OFFSET_MOVED_TO_TIERED_STORAGE, and rebuilds the leader-epoch cache and producer snapshot from remote.