feat(inkless): allow diskless switch only when remote storage is enabled [KC-217]#662
Closed
EelisK wants to merge 1 commit into
Closed
feat(inkless): allow diskless switch only when remote storage is enabled [KC-217]#662EelisK wants to merge 1 commit into
EelisK wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens classic→diskless topic switching by requiring remote.storage.enable (remote log storage) to be enabled before allowing initiation of the diskless switch, and updates unit/integration tests to reflect the new precondition.
Changes:
- Added a controller-side precondition check to reject initiating a diskless switch unless remote storage is enabled.
- Updated
ReplicationControlManagerTestscenarios to setremote.storage.enable=truewhere switches are expected to be evaluated/allowed. - Updated
InklessTopicTypeSwitcherClusterTestto setremote.storage.enable=truealongsidediskless.enable=trueduring switch operations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java | Adds remote-storage-enabled gating during initiation of classic→diskless switch. |
| metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java | Updates existing tests and adds new ones to cover acceptance/rejection based on remote storage enablement. |
| core/src/test/java/kafka/server/InklessTopicTypeSwitcherClusterTest.java | Ensures integration switch flows explicitly enable remote storage when enabling diskless. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
EelisK
force-pushed
the
EelisK/KC-86
branch
2 times, most recently
from
aa0ec1c to
3e7e905
Compare
EelisK
changed the title
EelisK
changed the title
Member
Author
|
Closing in favor of https://aiven.atlassian.net/browse/KC-293 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.