Skip to content

fix: properly template extraEnv values - #874

Open
jessebye wants to merge 1 commit into
airflow-helm:mainfrom
jessebye:patch-1
Open

fix: properly template extraEnv values#874
jessebye wants to merge 1 commit into
airflow-helm:mainfrom
jessebye:patch-1

Conversation

@jessebye

@jessebye jessebye commented Jul 18, 2024

Copy link
Copy Markdown

What issues does your PR fix?

#879

What does your PR do?

Runs extraEnv values through tpl so users can utilize templating in their values.

Checklist

For all Pull Requests

For releasing ONLY

@jessebye
jessebye requested a review from thesuperzapper as a code owner July 18, 2024 21:56
@jessebye jessebye changed the title Properly template extraEnv and extraEnvFrom values Properly template extraEnv values Jul 18, 2024

@montanapayne montanapayne left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice++

@jessebye

Copy link
Copy Markdown
Author

@thesuperzapper Hey, sorry to bother, but would you be able to give this a look? We're currently maintaining a separate fork just for this reason.

@jessebye jessebye changed the title Properly template extraEnv values fix: properly template extraEnv values Aug 21, 2024
@thesuperzapper

Copy link
Copy Markdown
Member

@jessebye please don't cut a release in this PR, only make template changes.

Also, we might want to include a small blurb about this in our docs (which live in markdown files on this repo):

Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>
Signed-off-by: jessebye <8467862+jessebye@users.noreply.github.com>
@jessebye

Copy link
Copy Markdown
Author

@thesuperzapper Ok, did a quick rebase and updated the documentation to mention use of templating in extraEnv. Please let me know if there are any other changes you'd like to see.

@jessebye

jessebye commented Dec 3, 2024

Copy link
Copy Markdown
Author

@thesuperzapper next steps? Can this be merged?

@jessebye

Copy link
Copy Markdown
Author

@thesuperzapper Sorry to bump this again, but we could really use this feature and the alternative is either to maintain a forked version of the repo for this one thing, or try to switch all of our config over to the official chart 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants