Skip to content

Feature/iframe tooltip render - #1848

Open
lapidus wants to merge 2 commits into
airbnb:masterfrom
datastory-org:feature/iframe-tooltip-render
Open

Feature/iframe tooltip render#1848
lapidus wants to merge 2 commits into
airbnb:masterfrom
datastory-org:feature/iframe-tooltip-render

Conversation

@lapidus

@lapidus lapidus commented Jun 3, 2024

Copy link
Copy Markdown

馃殌 Enhancements

Aims to make XYChart tooltips work in iFrame context.

@williaster

williaster commented Jun 6, 2024

Copy link
Copy Markdown
Collaborator

Hey @lapidus thanks so much for the PR, could you add a screenshot/video of the fixed trigger and positioning?

@lapidus

lapidus commented Jun 6, 2024

Copy link
Copy Markdown
Author

Thank you @williaster. The trigger is fixed (the mouseover etc. fires as expected and the tooltips shows up) but I didn't get the positioning 100% right in the PR yet.

I started adding iframe offset logic to this file:
packages/visx-xychart/src/components/Tooltip.tsx

Feel free to add any suggestions to the PR. I'll keep hacking a bit on it and add screenshots 馃憤

Thanks for the support and a wonderful lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XYChart Tooltip not working in Iframe

2 participants