Skip to content

feat(agent): stop PageBroker on termination signals #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dfeigin-nv wants to merge 1 commit into from
Open

feat(agent): stop PageBroker on termination signals #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion agent/pagebroker/daemon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#include <arpa/inet.h>
#include <errno.h>
#include <signal.h>
#include <sys/socket.h>
#include <sys/un.h>

Expand All @@ -20,6 +21,13 @@ using snapshot::pagebroker::Response;
namespace {
constexpr uint32_t kMaxMessageSize = 64 << 10; // 64 KB
enum ArgumentIndex { kSocketPath = 1, kStagingDirectory, kArgumentCount };
volatile sig_atomic_t shutting_down;

void
Stop(int)
{
shutting_down = 1;
}

bool
ReadAll(int fd, void* buffer, size_t size)
Expand Down Expand Up @@ -102,6 +110,14 @@ main(int argc, char** argv)
return 2;
}

struct sigaction action {};
action.sa_handler = Stop;
sigemptyset(&action.sa_mask);
if (sigaction(SIGINT, &action, nullptr) < 0 || sigaction(SIGTERM, &action, nullptr) < 0) {
std::cerr << "install signal handler: " << std::strerror(errno) << '\n';
return 1;
}

const fs::path socket_path(argv[kSocketPath]);
std::error_code error;
fs::create_directories(socket_path.parent_path(), error);
Expand Down Expand Up @@ -135,7 +151,7 @@ main(int argc, char** argv)
}

Broker broker(argv[kStagingDirectory]);
for (;;) {
while (!shutting_down) {
FileDescriptor connection(accept(listener.get(), nullptr, nullptr));
Comment thread
dfeigin-nv marked this conversation as resolved.
if (connection.get() < 0) {
if (errno != EINTR)
Expand Down