perf(snapshot): remove duplicate CustomStorage restore prefetch - #121
Open
hhzhang16 wants to merge 1 commit into
Conversation
hhzhang16
requested review from
Ronkahn21,
danbar2,
dfeigin-nv,
galletas1712,
hutm,
julienmancuso,
oleg-kushniriov,
shayasoolin and
shmuel-runai
as code owners
August 26, 2026 23:25
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Signed-off-by: Hannah Zhang <hannahz@nvidia.com>
hhzhang16
force-pushed
the
hannahz/customstorage-single-read-restore
branch
from
August 27, 2026 14:15
53d9429 to
026a892
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes Snapshot's separate full-artifact CustomStorage prefetch so each CUDA extent is read once during restore by the authoritative CUDA helper.
Why
The existing POSIX restore path reads every CUDA extent twice:
The first read is best-effort only. It is not authoritative and does not replace the helper's extent validation or transfer. For large checkpoints, the extra read dominates restore wall time even when it overlaps CRIU.
Main changes
TRT-LLM TP4/EP4 + GMS result
The controlled diagnostic used DSV4 Flash NVFP4, TP4/EP4, 1M context, 64 sequences, GMS V1, and Snapshot POSIX CustomStorage on one B200 node. The artifact contained 328,162,344,960 engine CustomStorage bytes, 195,723,001,856 GMS CustomStorage bytes, and about 19.7 GB of non-CUDA/CRIU data.
The CUDA phases remained essentially flat while the separate 115.5-second GMS and 192.1-second engine prefetch reads disappeared. That isolates the gain to eliminating duplicate storage I/O rather than changing CUDA transfer semantics.
The successful restore also passed restored-owner GMS validation, recreated the four-rank NCCL communicator, produced an exact all-reduce result of 10.0 on every rank, and completed post-restore inference.