Skip to content

refactor(cuda): decompose CustomStorage helper - #119

Open
hhzhang16 wants to merge 1 commit into
hannahz/customstorage-snapshot-v2from
hannahz/dep-1187-decompose-snapshot-cuda-checkpoint-helper-implementation
Open

refactor(cuda): decompose CustomStorage helper#119
hhzhang16 wants to merge 1 commit into
hannahz/customstorage-snapshot-v2from
hannahz/dep-1187-decompose-snapshot-cuda-checkpoint-helper-implementation

Conversation

@hhzhang16

Copy link
Copy Markdown

Summary

Follow-up to #109 and #96 that decomposes the qualified CUDA CustomStorage helper; does not change its protocol or behavior. It does not need to merge in the initial CustomStorage code-freeze window.

Source ownership

flowchart LR
    CLI["main.cpp<br/>CLI dispatch"] --> Server["daemon_server.*<br/>socket, health, shutdown"]
    Server --> CUDA["cuda_operation.*<br/>driver operation + context lifetime"]
    CUDA --> Scheduler["transfer_scheduler.*<br/>workers, deadline, cancellation"]
    Scheduler --> Adapter["transfer_engine.*<br/>Snapshot-local NIXL POSIX adapter"]
Loading

Main changes

  • main.cpp: reduced to CLI parsing and command dispatch

  • daemon_server: Unix-socket serving, health requests, shutdown, and RPC response handling

  • cuda_operation: CUDA initialization, operation completion, and target-scoped primary context lifetime

  • transfer_scheduler: per-extent worker creation, shared deadline, sibling cancellation, and
    result aggregation

  • Preserves the existing cancellation test and adds scheduler empty-batch, invalid-result, and backend-failure coverage.

  • standalone and production Docker targets to build and test

  • No change to CUDA operation ordering, timeout behavior, unknown-outcome handling, target identity, or retained-context lifetime.

  • Exact-image legacy and POSIX Qwen3-0.6B checkpoint/restore/inference smoke pass

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 943da77c-7ab5-4c47-8621-d8a13639de5a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Hannah Zhang <hannahz@nvidia.com>
@hhzhang16
hhzhang16 force-pushed the hannahz/dep-1187-decompose-snapshot-cuda-checkpoint-helper-implementation branch from 9ac46f2 to d86ee32 Compare August 27, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant