Skip to content

feat(snapshot): stop PageBroker on termination signals - #13166

Closed
dfeigin-nv wants to merge 1 commit into
pagebroker-daemon-serverfrom
pagebroker-daemon-shutdown
Closed

feat(snapshot): stop PageBroker on termination signals#13166
dfeigin-nv wants to merge 1 commit into
pagebroker-daemon-serverfrom
pagebroker-daemon-shutdown

Conversation

@dfeigin-nv

@dfeigin-nv dfeigin-nv commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Stops the PageBroker accept loop on SIGTERM and SIGINT.

Validation: make -C deploy/snapshot/pagebroker daemon test; an idle daemon exits after SIGTERM.

@github-actions github-actions Bot added the feat label Aug 13, 2026
@dfeigin-nv
dfeigin-nv marked this pull request as ready for review August 13, 2026 08:03
@dfeigin-nv
dfeigin-nv requested a review from a team as a code owner August 13, 2026 08:03

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread deploy/snapshot/pagebroker/daemon.cpp
@datadog-official

datadog-official Bot commented Aug 13, 2026

Copy link
Copy Markdown

Pipelines  Tests

⚠️ Warnings

🚦 6 Pipeline jobs failed

Pre Merge | pre-commit   View in Datadog   GitHub Actions

🔧 Fix in code. This looks caused by changes in this PR. Generated files are not up to date. Please run 'pre-commit install' and commit the changes.

Docs link check | lychee   View in Datadog   GitHub Actions

See error 7 requests returned a 404 Not Found status. URLs include: https://docs.nvidia.com/dynamo/latest/kubernetes-deployment/start-here/installation-guide and https://xgrammar.mlc.ai/docs/structural_tag/structural_tag_api.html.

PR | DGDR Deploy Test / CPU / lifecycle   View in Datadog   GitHub Actions

See error Missing required fields: repository and operator_tag when registry is set.

View all 6 failed jobs.

📋 Copy prompt for your agent
CI on my pull request is failing. Help me find and fix the root cause of each failing job below — they were flagged as caused by changes in this PR, so focus on the diff. For each job, explain the failure and propose a fix.

Branch: pagebroker-daemon-shutdown

Pre Merge | pre-commit
Commit: 8b2cfee182bfb948d89e9bc93ea54cca3a902380
Error (code / build):
Generated files are not up to date. Please run 'pre-commit install' and commit the changes.
CI job: https://github.com/ai-dynamo/dynamo/actions/runs/31950891488/job/95174070683

ℹ️ Info

🔄 Datadog auto-retried 4 jobs - 2 passed on retry View in Datadog

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 48.99% (-2.19%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8b2cfee | Docs | Datadog PR Page | Give us feedback!

@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-daemon-shutdown branch from 2506354 to 5d5cc24 Compare August 13, 2026 11:59
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-daemon-shutdown branch 2 times, most recently from b394a82 to 447573e Compare August 16, 2026 08:51
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-daemon-shutdown branch 2 times, most recently from 4499675 to c957ecb Compare August 16, 2026 10:34
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-daemon-shutdown branch from c957ecb to 0dc4f90 Compare August 16, 2026 11:33
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-daemon-shutdown branch from 0dc4f90 to a16c7d3 Compare August 16, 2026 13:29
@dfeigin-nv

Copy link
Copy Markdown
Contributor Author

Moved to ai-dynamo/snapshot#89.

@dfeigin-nv dfeigin-nv closed this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant