Skip to content

feat(snapshot): add PageBroker Unix socket server - #13165

Closed
dfeigin-nv wants to merge 2 commits into
pagebroker-nsmountfrom
pagebroker-daemon-server
Closed

feat(snapshot): add PageBroker Unix socket server#13165
dfeigin-nv wants to merge 2 commits into
pagebroker-nsmountfrom
pagebroker-daemon-server

Conversation

@dfeigin-nv

@dfeigin-nv dfeigin-nv commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Adds the PageBroker Unix-socket daemon. It accepts one framed protobuf request per connection and rejects malformed or oversized frames.

Validation: make -C deploy/snapshot/pagebroker daemon test and git diff --check pagebroker-nsmount...pagebroker-daemon-server.

@github-actions github-actions Bot added the feat label Aug 13, 2026
@dfeigin-nv
dfeigin-nv marked this pull request as ready for review August 13, 2026 08:03
@dfeigin-nv
dfeigin-nv requested review from a team as code owners August 13, 2026 08:03

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

View 1 additional finding in Devin Review.

Open in Devin Review

Comment thread deploy/snapshot/pagebroker/daemon.cpp
Comment thread deploy/snapshot/pagebroker/daemon.cpp
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@datadog-official

datadog-official Bot commented Aug 13, 2026

Copy link
Copy Markdown

Pipelines  Tests

⚠️ Warnings

🚦 3 Pipeline jobs failed

Pre Merge | pre-commit   View in Datadog   GitHub Actions

🔧 Fix in code. This looks caused by changes in this PR. Detected changes made by pre-commit hooks in 'deploy/snapshot/pagebroker/v1/pagebroker.proto'.

Docs link check | lychee   View in Datadog   GitHub Actions

See error Multiple 404 errors encountered while accessing API documentation URLs during execution.

Pre Merge | pre-merge-status-check   View in Datadog   GitHub Actions

📋 Copy prompt for your agent
CI on my pull request is failing. Help me find and fix the root cause of each failing job below — they were flagged as caused by changes in this PR, so focus on the diff. For each job, explain the failure and propose a fix.

Branch: pagebroker-daemon-server

Pre Merge | pre-commit
Commit: 9bd84414b8c11bde5578585c2f0f59f018fa7cbf
Error (code / build):
Detected changes made by pre-commit hooks in 'deploy/snapshot/pagebroker/v1/pagebroker.proto'.
CI job: https://github.com/ai-dynamo/dynamo/actions/runs/31950946132/job/95174263193

ℹ️ Info

🔄 Datadog auto-retried 2 jobs - 2 passed on retry View in Datadog

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 51.18% (+2.60%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9bd8441 | Docs | Datadog PR Page | Give us feedback!

@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-daemon-server branch 2 times, most recently from bdae8af to 155bc2b Compare August 16, 2026 08:51
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-daemon-server branch from 155bc2b to 48e0236 Compare August 16, 2026 10:16
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-daemon-server branch from 48e0236 to 3942026 Compare August 16, 2026 10:35
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-daemon-server branch from 3942026 to 0fd4c3d Compare August 16, 2026 11:33
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-daemon-server branch from 0fd4c3d to eb88ce3 Compare August 16, 2026 13:29
@dfeigin-nv

Copy link
Copy Markdown
Contributor Author

Moved to ai-dynamo/snapshot#88.

@dfeigin-nv dfeigin-nv closed this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant