-
-
Notifications
You must be signed in to change notification settings - Fork 250
Fixed TaskGroup and CancelScope exit issues on asyncio #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 31 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
278d4b6
WIP fix for #695
agronholm 437c507
WIP: debugging issue #695
agronholm d5cc818
WIP
agronholm d80af79
Tests pass on 3.9
agronholm a0baae7
Merge branch 'master' into fix-695
agronholm 8e3eeb1
Dropped Python 3.8 support
agronholm 903bc71
Dropped Python 3.8 support
agronholm fc63721
Merge branch 'master' into fix-695
agronholm c0a8222
Fixed subprocess finalization on cancellation
agronholm 9bd3c5e
Simplified the uncancellation logic
agronholm 2cd17af
Fixed the last failing test
agronholm 388af89
Added changelog note
agronholm bed20dc
Merge branch 'master' into fix-695
agronholm 5266431
Merge branch 'master' into fix-695
agronholm d19b506
Merge branch 'master' into fix-695
agronholm c03fc1d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 23e687c
Added the test case from #698
agronholm 7a6b1b0
Merge branch 'master' into fix-695
agronholm 3a90e74
Added new failing test case
agronholm ce5ddb0
Merge branch 'master' into fix-695
agronholm 947c56e
All tests pass now
agronholm 986baf5
Merge branch 'master' into fix-695
agronholm f1b2738
Enabled uvloop to be used in the test suite on Python 3.13
agronholm f9a1e1a
Merge branch 'master' into fix-695
agronholm 9bce41c
Merge branch 'master' into fix-695
agronholm 3435c72
Fixed inconsistent uncancellation by asyncio cancel scopes
agronholm 6eca825
Fixed another cancel scope issue
agronholm ab5ebb8
Fixed TaskGroup swallowing native cancellation exceptions
agronholm 093e065
Merge branch 'master' into fix-695
agronholm c082056
Updated the changelog
agronholm 9081213
Fixed CancelScope not uncancelling if it was exited with a real excep…
agronholm 2f68895
Fixed unbalanced parentheses
agronholm 15a4bcb
Update tests/test_taskgroups.py
agronholm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.