Fixed get_current_task() crashing with no current task on asyncio - #1312
Open
AmirF194 wants to merge 1 commit into
Open
Fixed get_current_task() crashing with no current task on asyncio#1312AmirF194 wants to merge 1 commit into
AmirF194 wants to merge 1 commit into
Conversation
run_sync_from_thread() runs its callback via call_soon_threadsafe(), outside of any Task, so current_task() is None there. get_current_task() built AsyncIOTaskInfo(None) anyway, and its WeakKeyDictionary lookup can't weak-reference None, raising an opaque TypeError instead of a clear error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE Erasing or replacing the contents of this template will result in your pull
request being summarily closed without consideration!
Changes
Fixes #773.
run_sync_from_thread()schedules its callback vialoop.call_soon_threadsafe(), which runs outside of anyasyncio.Task, socurrent_task()isNonein there.get_current_task()buildsAsyncIOTaskInfo(current_task())regardless, andAsyncIOTaskInfo.__init__does_task_states.get(task)on aWeakKeyDictionary, which can't weak-referenceNoneand blows up with the opaqueTypeErrorfrom the issue.Same "no current task" case #1163 already guards for
CancelScope.__enter__andcancel_shielded_checkpoint(), just a call site it doesn't touch. This raises a clearRuntimeErrorinstead, matching that shape.Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) which would fail without your patchdocs/), in case of behavior changes or newfeatures
docs/versionhistory.rst).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
If there are no entries after the last release, use
**UNRELEASED**as the version.If, say, your patch fixes issue #123, the entry should look like this:
If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.