-
-
Notifications
You must be signed in to change notification settings - Fork 254
Shared subprocess impl #1235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
graingert
wants to merge
17
commits into
agronholm:master
Choose a base branch
from
graingert:shared-subprocess-impl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Shared subprocess impl #1235
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
dfdcbbe
Add a shared, backend-agnostic subprocess implementation (#783)
graingert de574f8
Fix subprocess CI failures on macOS, Windows and pyright
graingert 0b1f034
Make Windows subprocess waiting loop-agnostic; support winloop pipes
graingert 56da967
Guard os.pidfd_open with hasattr for PyPy
graingert 504ae29
Prefer proactor.wait_for_handle for child wait on ProactorEventLoop
graingert 7c43044
Use UnregisterWaitEx to avoid a callback-after-cleanup race
graingert 2cbdf5d
Support subprocesses on the Windows SelectorEventLoop
graingert 91f7bf8
Extract asyncio.Runner backport; use it for the proactor thread
graingert 6f82b38
Add changelog entry for Windows SelectorEventLoop subprocess support
graingert 260440d
Add tests for reaping fallback, spawn failure and PathLike commands
graingert bfeed5f
more coverage
graingert 60e70ea
Merge branch 'master' of github.com:agronholm/anyio into shared-subpr…
graingert 2c39c1c
Apply suggestion from @graingert
graingert 48ce8a2
Apply suggestion from @graingert
graingert f667063
Apply suggestions from code review
graingert b45c111
add docs
graingert 7493cc8
Merge branch 'master' into shared-subprocess-impl
graingert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,26 @@ This library adheres to `Semantic Versioning 2.0 <http://semver.org/>`_. | |
|
|
||
| **UNRELEASED** | ||
|
|
||
| - Added support for running subprocesses on the asyncio ``SelectorEventLoop`` on Windows, | ||
| which does not support subprocesses natively; the pipe I/O is handled on a background | ||
| ``ProactorEventLoop`` (or winloop) thread | ||
| (`#783 <https://github.com/agronholm/anyio/issues/783>`_; PR by @graingert) | ||
| - Changed subprocess handling to use a shared, backend-agnostic implementation built on | ||
| ``subprocess.Popen()`` plus a small set of backend primitives (asynchronous pipes and | ||
| child-process reaping). This is used by the asyncio backend on all platforms and by the | ||
| Trio backend on POSIX (Trio keeps its native implementation on Windows), and removes the | ||
| reliance on undocumented backend internals | ||
| (`#783 <https://github.com/agronholm/anyio/issues/783>`_; PR by @graingert) | ||
| - Fixed several inconsistencies between the asyncio and Trio backends when working with | ||
| subprocesses (`#828 <https://github.com/agronholm/anyio/discussions/828>`_; PR by | ||
| @graingert): | ||
|
|
||
| * ``Process.wait()`` no longer waits for the standard streams to close, so it returns | ||
| promptly once the process exits, even when a pipe is inherited by a grandchild process | ||
| * ``Process.returncode`` now polls the process on both backends, so it no longer returns | ||
| a stale ``None`` after the process has exited | ||
| * Signalling an already-exited process via ``terminate()``, ``kill()`` or | ||
| ``send_signal()`` is now consistently a no-op instead of raising on asyncio | ||
|
Comment on lines
+8
to
+27
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This needs to be severely trimmed down before we merge. |
||
| - Changed the default name for a task spawned with ``TaskGroup.create_task(func())`` to | ||
| match the default task name for the analogous task spawned with | ||
| ``TaskGroup.start_soon(func)`` or ``TaskGroup.start(func)`` in more situations. | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.