Repository navigation
manifests: requests and 5 s probes for the two remaining BestEffort pods - #2955
Open
Davanum Srinivas (dims) wants to merge 1 commit into
Open
Davanum Srinivas (dims) wants to merge 1 commit into
Davanum Srinivas (dims) wants to merge 1 commit into
Conversation
Davanum Srinivas (dims)
force-pushed
the
control-plane-probe-shape
branch
2 times, most recently
from
October 20, 2026 11:17
b9241af to
3baef7c
Compare
Davanum Srinivas (dims)
marked this pull request as ready for review
October 20, 2026 13:31
Davanum Srinivas (dims)
force-pushed
the
control-plane-probe-shape
branch
9 times, most recently
from
October 27, 2026 12:34
95086d1 to
a66d786
Compare
Bowei Du (bowei)
added
area/dev-infra
area/identity
area/reliability
area/security
ate-idp-server and podcertificate-controller ran BestEffort, and the idp server's probes used the default 1 s timeout. On a node packed with sandboxes such a pod gets almost no CPU: an idp replica missed three liveness probes and was restarted with nothing wrong in it. Give both the CPU and memory requests the other control-plane pods have, and the idp server a 5 s probe timeout with a failure threshold of 6. Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Davanum Srinivas (dims)
force-pushed
the
control-plane-probe-shape
branch
from
October 28, 2026 11:06
a66d786 to
6a5edb6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ate-idp-server and podcertificate-controller run BestEffort, and the idp server's probes use the default 1 s timeout. On a node packed with sandboxes a BestEffort pod gets almost no CPU. One idp replica missed three liveness probes while the node's sandboxes were tearing down, and kubelet restarted it with nothing wrong in the process. #2557 gives the other control-plane pods requests and 5 s probes; these two were left out.
Change.
timeoutSeconds: 5withfailureThreshold: 6.Tests. Manifests only. The base and kind overlays render as the installer builds them, with the new fields on the idp Deployment; the installer's tests pass; the e2e jobs deploy the result.