Display error message for editing mac in a room without a linked inte… - #535
Draft
daenamnu wants to merge 3 commits into
Draft
Display error message for editing mac in a room without a linked inte…#535daenamnu wants to merge 3 commits into
daenamnu wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #535 +/- ##
===========================================
+ Coverage 29.60% 29.62% +0.01%
===========================================
Files 71 71
Lines 8613 8622 +9
===========================================
+ Hits 2550 2554 +4
- Misses 6063 6068 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lukasjuhrich
reviewed
Jul 4, 2026
lukasjuhrich
reviewed
Jul 4, 2026
| def change_mac_address(self, new_mac, host_name, password): | ||
| assert len(self.user_data.interfaces) == 1 | ||
| if self.user_data.interfaces == 0: | ||
| raise NoInterfaceExists |
Collaborator
There was a problem hiding this comment.
please document this exception on the method (and base class)
lukasjuhrich
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
developThis issue fixes #534