-
Notifications
You must be signed in to change notification settings - Fork 268
chore: release v1.6.0 #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -112,7 +112,7 @@ JSON reports now expose `findings[].runtimeConfidence` when AgentShield can dist | |
|
|
||
| ## What It Catches | ||
|
|
||
| **102 rules** across 5 categories, graded A–F with a 0–100 numeric score. | ||
| **268 rules** across 15 modules, graded A to F with a 0 to 100 numeric score. Recognized defenses are listed and never penalized. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Artifacts
|
||
|
|
||
| #### Scoring and recognized defenses | ||
|
|
||
|
|
@@ -127,7 +127,7 @@ The score starts at 100 per category and only findings deduct from it: critical | |
| | Credentials | Hardcoded passwords, database connection strings (postgres/mongo/mysql/redis), private key material | | ||
| | Env leaks | Secrets passed through environment variables in configs, `echo $SECRET` in hooks | | ||
|
|
||
| ### Permission Audit (10 rules) | ||
| ### Permission Audit (17 rules) | ||
|
|
||
| | What | Examples | | ||
| |------|----------| | ||
|
|
@@ -138,7 +138,7 @@ The score starts at 100 per category and only findings deduct from it: critical | |
| | Destructive git | `git push --force`, `git reset --hard` in allowed commands | | ||
| | Unrestricted network | `curl *`, `wget`, `ssh *`, `scp *` in allow list without scope | | ||
|
|
||
| ### Hook Analysis (34 rules) | ||
| ### Hook Analysis (40 rules) | ||
|
|
||
| | What | Examples | | ||
| |------|----------| | ||
|
|
@@ -155,7 +155,7 @@ The score starts at 100 per category and only findings deduct from it: critical | |
| | Clipboard access | `pbcopy`, `xclip`, `xsel`, `wl-copy` — exfiltration via clipboard | | ||
| | Log tampering | `journalctl --vacuum`, `rm /var/log`, `history -c` — anti-forensics | | ||
|
|
||
| ### MCP Server Security (23 rules) | ||
| ### MCP Server Security (49 rules) | ||
|
|
||
| | What | Examples | | ||
| |------|----------| | ||
|
|
@@ -207,7 +207,7 @@ AgentShield scans both active MCP config and repository-shipped MCP templates. | |
| - In template files, findings such as risky server type, remote URL transport, `npx -y`, unpinned packages, and environment inheritance are still valuable, but they should be interpreted as "this repo ships a risky MCP template" rather than "this MCP is definitely enabled right now." | ||
| - Aggregate findings like large MCP server counts are especially likely to overstate runtime exposure when the source file is a template catalog. | ||
|
|
||
| ### Agent Config Review (25 rules) | ||
| ### Agent Config Review (41 rules) | ||
|
|
||
| | What | Examples | | ||
| |------|----------| | ||
|
|
@@ -857,10 +857,10 @@ src/ | |
| ├── rules/ | ||
| │ ├── index.ts Rule registry | ||
| │ ├── secrets.ts Secret detection (10 rules, 14 patterns) | ||
| │ ├── permissions.ts Permission audit (10 rules) | ||
| │ ├── mcp.ts MCP server security (23 rules) | ||
| │ ├── hooks.ts Hook analysis (34 rules) | ||
| │ └── agents.ts Agent config review (25 rules) | ||
| │ ├── permissions.ts Permission audit (17 rules) | ||
| │ ├── mcp.ts MCP server security (26 rules) | ||
| │ ├── hooks.ts Hook analysis (40 rules) | ||
| │ └── agents.ts Agent config review (41 rules) | ||
|
Comment on lines
+860
to
+863
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Synchronize the rule inventory before publishing. The changed architecture tree lists five rule files, while Line 115 claims 268 rules across 15 modules. Lines 840-845 still report the old 102-rule total and old category counts. The MCP section reports 49 rules, but 🤖 Prompt for AI Agents |
||
| ├── reporter/ | ||
| │ ├── score.ts Scoring engine (A-F grades) | ||
| │ ├── terminal.ts Color terminal output | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🤖 get_repo_knowledge executed:
get_repo_knowledge affaan-m/agentshield /tmp/coderabbit-repo-knowledge/affaan-m-agentshield-51f67cff/conventionsLength of output: 2987
🏁 Script executed:
Repository: affaan-m/agentshield
Length of output: 50376
🏁 Script executed:
Repository: affaan-m/agentshield
Length of output: 1527
🏁 Script executed:
Repository: affaan-m/agentshield
Length of output: 864
Do not state that the floating
v1tag points to v1.6.0.The remote
v1tag currently points to the v1.5.0 release commit, and nov1.6.0tag exists. Use conditional wording in both locations until npm verification and the tag update are complete:CHANGELOG.md#L63release-draft.md#L38📍 Affects 2 files
CHANGELOG.md#L63-L63(this comment)release-draft.md#L38-L38🤖 Prompt for AI Agents