Skip to content

Program crashes when we try to perform factorize method on any value … #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aditya3434 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Program crashes when we try to perform factorize method on any value … #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21e1f06
Program crashes when we try to perform factorize method on any value …
aditya3434 Mar 28, 2020
9f81c10
Update combinatorics.py
aditya3434 Mar 28, 2020
248fe02
Fixed issue #223.
aditya3434 Mar 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions visma/discreteMaths/combinatorics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ def factorial(tokens):
tokens, _, _, _, _ = simplify(tokens)
animation = []
comments = []
result = []

if (isinstance(tokens[0], Constant) & len(tokens) == 1):
value = int(tokens[0].calculate())
if value == 0:
Expand All @@ -40,9 +42,11 @@ def factorial(tokens):
comments += [['Expanding the factorial as']]
animation += [resultTokens]
result, _, _, _, _ = simplify(resultTokens)
token_string = tokensToString(result)
comments += [['Hence result: ']]
animation += [tokenizer('f = ' + token_string)]

token_string = tokensToString(result)
comments += [['Hence result: ']]
animation += [tokenizer('f = ' + token_string)]

return result, [], token_string, animation, comments


Expand Down
1 change: 1 addition & 0 deletions visma/gui/window.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,7 @@ def initUI(self):

hbox.addWidget(splitter1)
self.setLayout(hbox)
self.textChangeTrigger()

self.logBox.append(logger.info('UI Initialised...'))

Expand Down